]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
staging: gpib: Replace kmalloc/memset with kzalloc.
authorRohit Chavan <roheetchavan@gmail.com>
Wed, 16 Oct 2024 10:34:06 +0000 (16:04 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Oct 2024 14:08:38 +0000 (16:08 +0200)
This patch replaces kmalloc + memset with kzalloc in the GPIB driver.

Signed-off-by: Rohit Chavan <roheetchavan@gmail.com>
Reviewed-by: Dave Penkler <dpenkler@gmail.com>
Link: https://lore.kernel.org/r/20241016103406.1618448-1-roheetchavan@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gpib/agilent_82350b/agilent_82350b.c
drivers/staging/gpib/cb7210/cb7210.c
drivers/staging/gpib/gpio/gpib_bitbang.c
drivers/staging/gpib/hp_82335/hp82335.c
drivers/staging/gpib/hp_82341/hp_82341.c
drivers/staging/gpib/ines/ines_gpib.c
drivers/staging/gpib/tnt4882/mite.c
drivers/staging/gpib/tnt4882/tnt4882_gpib.c

index 1296db4d47c638d7e4ea1adbf5c6ebbd79236a66..cff555447ee9728c03ad402223ae6c44b0f330ad 100644 (file)
@@ -518,10 +518,9 @@ void agilent_82350b_return_to_local(gpib_board_t *board)
 int agilent_82350b_allocate_private(gpib_board_t *board)
 
 {
-       board->private_data = kmalloc(sizeof(struct agilent_82350b_priv), GFP_KERNEL);
+       board->private_data = kzalloc(sizeof(struct agilent_82350b_priv), GFP_KERNEL);
        if (!board->private_data)
                return -ENOMEM;
-       memset(board->private_data, 0, sizeof(struct agilent_82350b_priv));
        return 0;
 }
 
index 59f6dde3d9661f8118a32f9e89b1c29347ac7903..d32576c21988522efc6f8c6e0aefa8698a06f264 100644 (file)
@@ -1199,10 +1199,9 @@ static int cb_gpib_probe(struct pcmcia_device *link)
        DEBUG(0, "%s(0x%p)\n", __func__, link);
 
        /* Allocate space for private device-specific data */
-       info = kmalloc(sizeof(*info), GFP_KERNEL);
+       info = kzalloc(sizeof(*info), GFP_KERNEL);
        if (!info)
                return -ENOMEM;
-       memset(info, 0, sizeof(*info));
 
        info->p_dev = link;
        link->priv = info;
index 81a952beee0dcfef4a4b8bef18218e7d18240f1e..847e4bea2cb177f372bcdefb52c4025e16502583 100644 (file)
@@ -1105,10 +1105,9 @@ static int bb_line_status(const gpib_board_t *board)
 
 static int allocate_private(gpib_board_t *board)
 {
-       board->private_data = kmalloc(sizeof(struct bb_priv), GFP_KERNEL);
+       board->private_data = kzalloc(sizeof(struct bb_priv), GFP_KERNEL);
        if (!board->private_data)
                return -1;
-       memset(board->private_data, 0, sizeof(struct bb_priv));
        return 0;
 }
 
index 4e277997684bd7ffa0b91c16db8658591b1e62ea..cf92fc0b33377578ac5d80487f8d291deb0b22e0 100644 (file)
@@ -201,10 +201,9 @@ return_to_local : hp82335_return_to_local,
 
 int hp82335_allocate_private(gpib_board_t *board)
 {
-       board->private_data = kmalloc(sizeof(struct hp82335_priv), GFP_KERNEL);
+       board->private_data = kzalloc(sizeof(struct hp82335_priv), GFP_KERNEL);
        if (!board->private_data)
                return -1;
-       memset(board->private_data, 0, sizeof(struct hp82335_priv));
        return 0;
 }
 
index d37dd8335523c652525bd5cd067c788f3ab2016d..8ad1c885a9fb60aae9035e555830706275a26900 100644 (file)
@@ -459,10 +459,9 @@ return_to_local : hp_82341_return_to_local,
 
 int hp_82341_allocate_private(gpib_board_t *board)
 {
-       board->private_data = kmalloc(sizeof(struct hp_82341_priv), GFP_KERNEL);
+       board->private_data = kzalloc(sizeof(struct hp_82341_priv), GFP_KERNEL);
        if (!board->private_data)
                return -ENOMEM;
-       memset(board->private_data, 0, sizeof(struct hp_82341_priv));
        return 0;
 }
 
index 9dbbdb048b9fbb0295ce399a263081b731e8bbb1..87f9d3789c5ff1a0a1ff4af6477b012a2bfe7d6c 100644 (file)
@@ -1063,10 +1063,9 @@ static int ines_gpib_probe(struct pcmcia_device *link)
        DEBUG(0, "%s(0x%p)\n", __func__ link);
 
        /* Allocate space for private device-specific data */
-       info = kmalloc(sizeof(*info), GFP_KERNEL);
+       info = kzalloc(sizeof(*info), GFP_KERNEL);
        if (!info)
                return -ENOMEM;
-       memset(info, 0, sizeof(*info));
 
        info->p_dev = link;
        link->priv = info;
index 882cc4bc122e707133d2a9d069a733092f688aef..0edf34d243e9e897806bfc2b575b14dc98dda97d 100644 (file)
@@ -57,12 +57,10 @@ void mite_init(void)
        for (pcidev = pci_get_device(PCI_VENDOR_ID_NATINST, PCI_ANY_ID, NULL);
                pcidev;
                pcidev = pci_get_device(PCI_VENDOR_ID_NATINST, PCI_ANY_ID, pcidev)) {
-               mite = kmalloc(sizeof(*mite), GFP_KERNEL);
+               mite = kzalloc(sizeof(*mite), GFP_KERNEL);
                if (!mite)
                        return;
 
-               memset(mite, 0, sizeof(*mite));
-
                mite->pcidev = pcidev;
                pci_dev_get(mite->pcidev);
                mite->next = mite_devices;
index ef4b9ce36741ea519a2a3f59c6bd5486599a2a4d..0a850926c118c2f5b3366495fcb1412f4e37a792 100644 (file)
@@ -1644,10 +1644,9 @@ static int ni_gpib_probe(struct pcmcia_device *link)
        DEBUG(0, "%s(0x%p)\n", __func__, link);
 
        /* Allocate space for private device-specific data */
-       info = kmalloc(sizeof(*info), GFP_KERNEL);
+       info = kzalloc(sizeof(*info), GFP_KERNEL);
        if (!info)
                return -ENOMEM;
-       memset(info, 0, sizeof(*info));
 
        info->p_dev = link;
        link->priv = info;