]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
hwmon: (lm75) simplify lm75_write_config()
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Thu, 19 Dec 2024 22:55:23 +0000 (23:55 +0100)
committerGuenter Roeck <linux@roeck-us.net>
Fri, 20 Dec 2024 14:56:32 +0000 (06:56 -0800)
After previous refactoring, it is now possible to make
lm75_write_config() a simple inline function.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20241219225522.3490-8-wsa+renesas@sang-engineering.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/lm75.c

index b8889392d5daa584f571a062d61dbe7788a83b0f..b03e760cf3a1c5124fcec41ebc34f09769aef812 100644 (file)
@@ -340,17 +340,11 @@ static inline long lm75_reg_to_mc(s16 temp, u8 resolution)
        return ((temp >> (16 - resolution)) * 1000) >> (resolution - 8);
 }
 
-static int lm75_write_config(struct lm75_data *data, u16 set_mask,
-                            u16 clr_mask)
+static inline int lm75_write_config(struct lm75_data *data, u16 set_mask,
+                                   u16 clr_mask)
 {
-       int err;
-
-       err = regmap_update_bits(data->regmap, LM75_REG_CONF,
-                                clr_mask | LM75_SHUTDOWN, set_mask);
-       if (err)
-               return err;
-
-       return 0;
+       return regmap_update_bits(data->regmap, LM75_REG_CONF,
+                                 clr_mask | LM75_SHUTDOWN, set_mask);
 }
 
 static irqreturn_t lm75_alarm_handler(int irq, void *private)