]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
r8169: enable EEE at 2.5G per default on RTL8125B
authorHeiner Kallweit <hkallweit1@gmail.com>
Thu, 17 Oct 2024 20:27:44 +0000 (22:27 +0200)
committerAndrew Lunn <andrew@lunn.ch>
Sun, 20 Oct 2024 16:06:47 +0000 (11:06 -0500)
Register a6d/12 is shadowing register MDIO_AN_EEE_ADV2. So this line
disables advertisement of EEE at 2.5G. Latest vendor driver r8125
doesn't do this (any longer?), so this mode seems to be safe.
EEE saves quite some energy, therefore enable this mode per default.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Message-ID: <95dd5a0c-09ea-4847-94d9-b7aa3063e8ff@gmail.com>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
drivers/net/ethernet/realtek/r8169_phy_config.c

index cf29b120848269a0ca13a00e45743023239e8316..d504abba75652cdc77bdf851ef9d3949250867a7 100644 (file)
@@ -99,7 +99,6 @@ static void rtl8125a_config_eee_phy(struct phy_device *phydev)
 
 static void rtl8125b_config_eee_phy(struct phy_device *phydev)
 {
-       phy_modify_paged(phydev, 0xa6d, 0x12, 0x0001, 0x0000);
        phy_modify_paged(phydev, 0xa6d, 0x14, 0x0010, 0x0000);
        phy_modify_paged(phydev, 0xa42, 0x14, 0x0080, 0x0000);
        phy_modify_paged(phydev, 0xa4a, 0x11, 0x0200, 0x0000);