]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mptcp: remove unneeded mptcp_move_skb()
authorPaolo Abeni <pabeni@redhat.com>
Sat, 27 Sep 2025 09:40:41 +0000 (11:40 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 30 Sep 2025 01:23:35 +0000 (18:23 -0700)
Since commit b7535cfed223 ("mptcp: drop legacy code around RX EOF"),
sk_shutdown can't change during the main recvmsg loop, we can drop
the related race breaker.

Reviewed-by: Geliang Tang <geliang@kernel.org>
Tested-by: Geliang Tang <geliang@kernel.org>
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20250927-net-next-mptcp-rcv-path-imp-v1-5-5da266aa9c1a@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mptcp/protocol.c

index 832782e23740d22acda608966c29516666c9b111..26fbd9f6a3f7802c428e79c7f4e1da45aa9533e5 100644 (file)
@@ -2207,14 +2207,8 @@ static int mptcp_recvmsg(struct sock *sk, struct msghdr *msg, size_t len,
                                break;
                        }
 
-                       if (sk->sk_shutdown & RCV_SHUTDOWN) {
-                               /* race breaker: the shutdown could be after the
-                                * previous receive queue check
-                                */
-                               if (__mptcp_move_skbs(sk))
-                                       continue;
+                       if (sk->sk_shutdown & RCV_SHUTDOWN)
                                break;
-                       }
 
                        if (sk->sk_state == TCP_CLOSE) {
                                copied = -ENOTCONN;