]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/xe/guc: Log content of the failed G2H message
authorMichal Wajdeczko <michal.wajdeczko@intel.com>
Tue, 5 Nov 2024 17:30:29 +0000 (18:30 +0100)
committerMichal Wajdeczko <michal.wajdeczko@intel.com>
Thu, 7 Nov 2024 16:38:09 +0000 (17:38 +0100)
We are already logging an error once we failed to process a G2H
message, but then it's quite hard to extract the content of the
broken G2H message from the captured snapshot. Extend our error
log with the raw hexdump of the G2H message.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241105173032.1947-2-michal.wajdeczko@intel.com
drivers/gpu/drm/xe/xe_guc_ct.c

index 550eeed43903b4bc396e6c3b2b0f4a91ec3b9054..63bd91963eb18e6786ffb791bdb28e875bc38e01 100644 (file)
@@ -1299,8 +1299,8 @@ static int process_g2h_msg(struct xe_guc_ct *ct, u32 *msg, u32 len)
        }
 
        if (ret) {
-               xe_gt_err(gt, "G2H action 0x%04x failed (%pe)\n",
-                         action, ERR_PTR(ret));
+               xe_gt_err(gt, "G2H action %#04x failed (%pe) len %u msg %*ph\n",
+                         action, ERR_PTR(ret), hxg_len, (int)sizeof(u32) * hxg_len, hxg);
                CT_DEAD(ct, NULL, PROCESS_FAILED);
        }