]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
led: triggers: Break the for loop after default trigger is found
authorJacek Anaszewski <jacek.anaszewski@gmail.com>
Mon, 10 Dec 2018 09:29:57 +0000 (10:29 +0100)
committerJacek Anaszewski <jacek.anaszewski@gmail.com>
Mon, 10 Dec 2018 20:10:42 +0000 (21:10 +0100)
It is of no avail to continue iterating through registered
triggers in the led_trigger_set_default() after the trigger to set
has been found. Add "break" statement to fix this omission.

Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
drivers/leds/led-triggers.c

index 17d73db1456ebb4009c9dfa396820aa2e2485acd..52b12e601ebe8fbb7d03df3fc49bcd67c3e16806 100644 (file)
@@ -200,8 +200,10 @@ void led_trigger_set_default(struct led_classdev *led_cdev)
        down_read(&triggers_list_lock);
        down_write(&led_cdev->trigger_lock);
        list_for_each_entry(trig, &trigger_list, next_trig) {
-               if (!strcmp(led_cdev->default_trigger, trig->name))
+               if (!strcmp(led_cdev->default_trigger, trig->name)) {
                        led_trigger_set(led_cdev, trig);
+                       break;
+               }
        }
        up_write(&led_cdev->trigger_lock);
        up_read(&triggers_list_lock);