]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
dnsdist: Increase the time granted for the "timeout then restart" test 15939/head
authorRemi Gacogne <remi.gacogne@powerdns.com>
Tue, 29 Jul 2025 09:42:24 +0000 (11:42 +0200)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Tue, 29 Jul 2025 09:44:18 +0000 (11:44 +0200)
This test fails from time to time in our CI. After investigation, it
turns out that sometimes the response comes just a few milliseconds
after the 3 seconds timeout has expired:

```
Got answer from 127.0.0.1:14191, relayed to 127.0.0.1:36139 (UDP), took 3.00105e+06 us
```

So let's use a slightly larger timeout of 4 seconds. It will not add
any delay if the response is received faster than that and will hopefully
reduce the number of spurious failures.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
regression-tests.dnsdist/test_TimeoutResponse.py

index e75b09970988b7fbf028a458553e9bf2adcca372..7180c9067912038c0afc9278939ae8529756b496 100644 (file)
@@ -102,7 +102,7 @@ class TestTimeoutBackendUdpTcp(DNSDistTest):
 
         for method in ("sendUDPQuery", "sendTCPQuery", "sendDOQQueryWrapper", "sendDOH3QueryWrapper", "sendDOTQueryWrapper", "sendDOHWithNGHTTP2QueryWrapper"):
             sender = getattr(self, method)
-            (_, receivedResponse) = sender(query, response=None, useQueue=False, timeout=3)
+            (_, receivedResponse) = sender(query, response=None, useQueue=False, timeout=4)
             self.assertTrue(receivedResponse)
             self.assertEqual(receivedResponse, expectedResponse)