]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
soc: qcom: aoss: simplify with scoped for each OF child loop
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tue, 13 Aug 2024 13:09:48 +0000 (15:09 +0200)
committerBjorn Andersson <andersson@kernel.org>
Thu, 15 Aug 2024 03:14:43 +0000 (22:14 -0500)
Use scoped for_each_available_child_of_node_scoped() when iterating over
device nodes to make code a bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240813-b4-cleanup-h-of-node-put-other-v1-2-cfb67323a95c@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/soc/qcom/qcom_aoss.c

index ca2f6b7629ce0388f5263b548c3864a4a3529318..60af26667bce459389e1725e3d4ff852706ebd9a 100644 (file)
@@ -394,7 +394,7 @@ static int qmp_cooling_device_add(struct qmp *qmp,
 
 static int qmp_cooling_devices_register(struct qmp *qmp)
 {
-       struct device_node *np, *child;
+       struct device_node *np;
        int count = 0;
        int ret;
 
@@ -407,15 +407,13 @@ static int qmp_cooling_devices_register(struct qmp *qmp)
        if (!qmp->cooling_devs)
                return -ENOMEM;
 
-       for_each_available_child_of_node(np, child) {
+       for_each_available_child_of_node_scoped(np, child) {
                if (!of_property_present(child, "#cooling-cells"))
                        continue;
                ret = qmp_cooling_device_add(qmp, &qmp->cooling_devs[count++],
                                             child);
-               if (ret) {
-                       of_node_put(child);
+               if (ret)
                        goto unroll;
-               }
        }
 
        if (!count)