Fix #2154

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8c28554d69137f54e95f1455866a88fb6b86e048..e6b28a7a6b45d264dbd44905cbb5cf683dd455dc 100644 (file)
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -19,6 +19,7 @@
 * #2157 Fix #1656 -> Allow border radius if only one `.control` in `.field`
 * #2091 Fix #2091 -> Remove CSS rule which causes `.tag.has-addons` to not work correctly
 * #2186 Fix #1130 -> Prevent `.dropdown` links underlining in `.message` component
+* Fix #2154 -> Move `.hero.is-fullheight-with-navbar` to `navbar.sass` file
 
 ### Deprecation
 

diff --git a/docs/css/bulma-docs.css b/docs/css/bulma-docs.css
index b33608ee25851dd7b9be5d4ab1aec25d019509f7..8cf4540c2c6cfae64450fba503d3eb590b64dee6 100644 (file)
--- a/docs/css/bulma-docs.css
+++ b/docs/css/bulma-docs.css
@@ -7159,6 +7159,10 @@ a.navbar-item:hover, a.navbar-item.is-active,
   }
 }
 
+.hero.is-fullheight-with-navbar {
+  min-height: calc(100vh - 3.25rem);
+}
+
 .pagination {
   font-size: 1rem;
   margin: -0.25rem;
@@ -10265,10 +10269,6 @@ label.panel-block:hover {
   min-height: 100vh;
 }
 
-.hero.is-fullheight-with-navbar {
-  min-height: calc(100vh - 3.25rem);
-}
-
 .hero-video {
   overflow: hidden;
 }

diff --git a/sass/components/navbar.sass b/sass/components/navbar.sass
index f11153d3f6c9f4c51cdde99db451555d7db1c489..dc90dd9d3cee26f886cf2a3c339cddcba81d11a5 100644 (file)
--- a/sass/components/navbar.sass
+++ b/sass/components/navbar.sass
@@ -420,3 +420,9 @@ a.navbar-item,
     &.is-active
       .navbar-link
         background-color: $navbar-item-hover-background-color
+
+// Combination
+
+.hero
+  &.is-fullheight-with-navbar
+    min-height: calc(100vh - #{$navbar-height})

diff --git a/sass/layout/hero.sass b/sass/layout/hero.sass
index db56b9f89c66c0c02dc68041df8da4e62b9e9590..d988040b3ae15882791ea023e88ccd487f787dff 100644 (file)
--- a/sass/layout/hero.sass
+++ b/sass/layout/hero.sass
@@ -109,8 +109,6 @@
     min-height: 50vh
   &.is-fullheight
     min-height: 100vh
-  &.is-fullheight-with-navbar
-    min-height: calc(100vh - #{$navbar-height})
 
 // Components