Update 26704 to include a null check on the right hand side as well.

diff --git a/common/dhcp-eval.5 b/common/dhcp-eval.5
index 7dff9c5ce390e0a6dc0b004c4be8814493830cd4..20c6fcb0c2ca6e4c420e99a300bb4b5cd1a7eaa4 100644 (file)
--- a/common/dhcp-eval.5
+++ b/common/dhcp-eval.5
@@ -1,6 +1,6 @@
-.\"    $Id: dhcp-eval.5,v 1.31 2010/07/02 23:09:14 sar Exp $
+.\"    $Id: dhcp-eval.5,v 1.32 2011/11/28 18:01:25 sar Exp $
 .\"
-.\" Copyright (c) 2009-2010 by Internet Systems Consortium, Inc. ("ISC")
+.\" Copyright (c) 2009-2011 by Internet Systems Consortium, Inc. ("ISC")
 .\" Copyright (c) 2004,2007 by Internet Systems Consortium, Inc. ("ISC")
 .\" Copyright (c) 1996-2003 by Internet Software Consortium
 .\"
@@ -133,8 +133,8 @@ extended regex(7) matching of the values of two data expressions, returning
 true if \fIdata-expression-1\fR matches against the regular expression
 evaluated by \fIdata-expression-2\fR, or false if it does not match or
 encounters some error.  If either the left-hand side or the right-hand side 
-are null, the result is also false.  The \fB~~\fR operator differs from the
-\fB~=\fR operator in that it is case-insensitive.
+are null or empty strings, the result is also false.  The \fB~~\fR operator
+differs from the \fB~=\fR operator in that it is case-insensitive.
 .RE
 .PP
 .I boolean-expression-1 \fBand\fR \fIboolean-expression-2\fR

diff --git a/common/tree.c b/common/tree.c
index 20b2bc6447c7cc4a30b2d20ac5ccf3dbaf0b336e..3c978b0975ba07080df1a09407c18593be9fc390 100644 (file)
--- a/common/tree.c
+++ b/common/tree.c
@@ -1120,7 +1120,7 @@ int evaluate_boolean_expression (result, packet, lease, client_state,
                *result = 0;
                memset(&re, 0, sizeof(re));
                if (bleft && bright &&
-                   (left.data != NULL) &&
+                   (left.data != NULL) && (right.data != NULL) &&
                    (regcomp(&re, (char *)right.data, regflags) == 0) &&
                    (regexec(&re, (char *)left.data, (size_t)0, NULL, 0) == 0))
                                *result = 1;