]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ACPICA: events/evxfregn: don't release the ContextMutex that was never acquired
authorDaniil Tatianin <d-tatianin@yandex-team.ru>
Fri, 22 Nov 2024 08:29:54 +0000 (11:29 +0300)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 12 Dec 2024 12:22:41 +0000 (13:22 +0100)
This bug was first introduced in c27f3d011b08, where the author of the
patch probably meant to do DeleteMutex instead of ReleaseMutex. The
mutex leak was noticed later on and fixed in e4dfe108371, but the bogus
MutexRelease line was never removed, so do it now.

Link: https://github.com/acpica/acpica/pull/982
Fixes: c27f3d011b08 ("ACPICA: Fix race in generic_serial_bus (I2C) and GPIO op_region parameter handling")
Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
Link: https://patch.msgid.link/20241122082954.658356-1-d-tatianin@yandex-team.ru
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/acpica/evxfregn.c

index 95f78383bbdba16bab4d0a2022c87780cf6615bb..bff2d099f4691ef7dd30f191029a7a477ac332b8 100644 (file)
@@ -232,8 +232,6 @@ acpi_remove_address_space_handler(acpi_handle device,
 
                        /* Now we can delete the handler object */
 
-                       acpi_os_release_mutex(handler_obj->address_space.
-                                             context_mutex);
                        acpi_ut_remove_reference(handler_obj);
                        goto unlock_and_exit;
                }