scsi: myrb: Simplify an alloc_ordered_workqueue() invocation

Let alloc_ordered_workqueue() format the workqueue name instead of calling
snprintf() explicitly.

Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20240822195944.654691-11-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/myrb.c b/drivers/scsi/myrb.c
index 140dc0e9ceadb542f1440a3fac47b4d2ae48a795..bfc2b835e61251af82b0eb4199a52482bd475cca 100644 (file)
--- a/drivers/scsi/myrb.c
+++ b/drivers/scsi/myrb.c
@@ -112,10 +112,8 @@ static bool myrb_create_mempools(struct pci_dev *pdev, struct myrb_hba *cb)
                return false;
        }
 
-       snprintf(cb->work_q_name, sizeof(cb->work_q_name),
-                "myrb_wq_%d", cb->host->host_no);
-       cb->work_q =
-               alloc_ordered_workqueue("%s", WQ_MEM_RECLAIM, cb->work_q_name);
+       cb->work_q = alloc_ordered_workqueue("myrb_wq_%d", WQ_MEM_RECLAIM,
+                                            cb->host->host_no);
        if (!cb->work_q) {
                dma_pool_destroy(cb->dcdb_pool);
                cb->dcdb_pool = NULL;

diff --git a/drivers/scsi/myrb.h b/drivers/scsi/myrb.h
index fb8eacfceee88d157120acf5b7fa0dbf94e8a6d7..78dc4136fb10c46e99a267f3c596a7231385dd2b 100644 (file)
--- a/drivers/scsi/myrb.h
+++ b/drivers/scsi/myrb.h
@@ -712,7 +712,6 @@ struct myrb_hba {
        struct Scsi_Host *host;
 
        struct workqueue_struct *work_q;
-       char work_q_name[20];
        struct delayed_work monitor_work;
        unsigned long primary_monitor_time;
        unsigned long secondary_monitor_time;