]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mm/shmem: remove unneeded xa_is_value() check in shmem_unuse_swap_entries()
authorKemeng Shi <shikemeng@huaweicloud.com>
Fri, 16 May 2025 17:09:39 +0000 (01:09 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Sun, 1 Jun 2025 05:46:11 +0000 (22:46 -0700)
As only value entry will be added to fbatch in shmem_find_swap_entries(),
there is no need to do xa_is_value() check in shmem_unuse_swap_entries().

Link: https://lkml.kernel.org/r/20250516170939.965736-6-shikemeng@huaweicloud.com
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Kairui Song <kasong@tencent.com>
Cc: kernel test robot <oliver.sang@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/shmem.c

index 07b8e1400c67a542e9d53039f15cdb2bd34f1d32..4b42419ce6b210cbe4f1f9e7d949a34c67c0cc4c 100644 (file)
@@ -1446,8 +1446,6 @@ static int shmem_unuse_swap_entries(struct inode *inode,
        for (i = 0; i < folio_batch_count(fbatch); i++) {
                struct folio *folio = fbatch->folios[i];
 
-               if (!xa_is_value(folio))
-                       continue;
                error = shmem_swapin_folio(inode, indices[i], &folio, SGP_CACHE,
                                        mapping_gfp_mask(mapping), NULL, NULL);
                if (error == 0) {