]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: SOF: Don't allow pointer operations on unconfigured streams
authorMark Brown <broonie@kernel.org>
Thu, 26 Mar 2026 14:52:41 +0000 (14:52 +0000)
committerMark Brown <broonie@kernel.org>
Fri, 10 Apr 2026 12:57:09 +0000 (13:57 +0100)
When reporting the pointer for a compressed stream we report the current
I/O frame position by dividing the position by the number of channels
multiplied by the number of container bytes. These values default to 0 and
are only configured as part of setting the stream parameters so this allows
a divide by zero to be configured. Validate that they are non zero,
returning an error if not

Fixes: c1a731c71359 ("ASoC: SOF: compress: Add support for computing timestamps")
Cc: stable@vger.kernel.org
Link: https://patch.msgid.link/20260326-asoc-compress-tstamp-params-v1-1-3dc735b3d599@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/compress.c

index f4c3e10e6344d438e4af0ab501886459c589c2b3..93f2376585dbf55b626391f0cee66ad1c5d971d2 100644 (file)
@@ -381,6 +381,9 @@ static int sof_compr_pointer(struct snd_soc_component *component,
        if (!spcm)
                return -EINVAL;
 
+       if (!sstream->channels || !sstream->sample_container_bytes)
+               return -EBUSY;
+
        tstamp->sampling_rate = sstream->sampling_rate;
        tstamp->copied_total = sstream->copied_total;
        tstamp->pcm_io_frames = div_u64(spcm->stream[cstream->direction].posn.dai_posn,