]> git.ipfire.org Git - thirdparty/rrdtool-1.x.git/commitdiff
src/rrd_fetch_libdbi.c: fix Coverity CID#26513 Buffer not null terminated
authorMarek Schimara <Marek.Schimara@bull.net>
Thu, 16 Jun 2016 13:57:27 +0000 (15:57 +0200)
committerMarek Schimara <Marek.Schimara@bull.net>
Thu, 23 Jun 2016 14:32:33 +0000 (16:32 +0200)
        CWE-170 / https://cwe.mitre.org/data/definitions/170.html

src/rrd_fetch_libdbi.c

index 4654761494a256e900c527390f61f9d28bd92795..b0ca2a664b5609d287950c14113c60ecd0f1e2c5 100644 (file)
@@ -435,7 +435,8 @@ rrd_fetch_fn_libdbi(
   separator=filename[3];
 
   /* copy filename for local modifications during parsing */
-  strncpy(filenameworkcopy,filename+5,sizeof(filenameworkcopy));
+  strncpy(filenameworkcopy,filename+5,sizeof(filenameworkcopy) - 1);
+  filenameworkcopy[sizeof(filenameworkcopy) - 1] = '\0';
 
   /* get the driver */
   table_help.dbdriver=tmpptr;