iio: adc: pac1921: add missing error return in probe()

This error path was intended to return, and not just print an error.  The
current code will lead to an error pointer dereference.

Fixes: 371f778b83cd ("iio: adc: add support for pac1921")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Matteo Martelli <matteomartelli3@gmail.com>
Link: https://patch.msgid.link/1fa4ab12-0939-477d-bc92-306fd32e4fd9@stanley.mountain
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

diff --git a/drivers/iio/adc/pac1921.c b/drivers/iio/adc/pac1921.c
index d04c6685d780b05ebb58f80f117056e4ee105a84..8200a47bdf215401d6b1c30b5e1f64d05ddd3d23 100644 (file)
--- a/drivers/iio/adc/pac1921.c
+++ b/drivers/iio/adc/pac1921.c
@@ -1168,8 +1168,8 @@ static int pac1921_probe(struct i2c_client *client)
 
        priv->regmap = devm_regmap_init_i2c(client, &pac1921_regmap_config);
        if (IS_ERR(priv->regmap))
-               dev_err_probe(dev, (int)PTR_ERR(priv->regmap),
-                             "Cannot initialize register map\n");
+               return dev_err_probe(dev, (int)PTR_ERR(priv->regmap),
+                                    "Cannot initialize register map\n");
 
        devm_mutex_init(dev, &priv->lock);