]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
btrfs: remove duplicated metadata folio flag update in end_bbio_meta_read()
authorQu Wenruo <wqu@suse.com>
Mon, 27 Jan 2025 02:30:49 +0000 (13:00 +1030)
committerDavid Sterba <dsterba@suse.com>
Mon, 17 Mar 2025 13:44:43 +0000 (14:44 +0100)
In that function we call set_extent_buffer_uptodate() or
clear_extent_buffer_uptodate(), which will already update the uptodate
flag for all the involved extent buffer folios.

Thus there is no need to update the folio uptodate flags again.

Just remove the open-coded part.

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/extent_io.c

index 112bf48c218c4553ee8a3064c1a9e644d42cb480..3b557f4fe632f76113e15504ad90830fe951e60d 100644 (file)
@@ -3505,10 +3505,7 @@ static void clear_extent_buffer_reading(struct extent_buffer *eb)
 static void end_bbio_meta_read(struct btrfs_bio *bbio)
 {
        struct extent_buffer *eb = bbio->private;
-       struct btrfs_fs_info *fs_info = eb->fs_info;
        bool uptodate = !bbio->bio.bi_status;
-       struct folio_iter fi;
-       u32 bio_offset = 0;
 
        /*
         * If the extent buffer is marked UPTODATE before the read operation
@@ -3530,19 +3527,6 @@ static void end_bbio_meta_read(struct btrfs_bio *bbio)
                set_bit(EXTENT_BUFFER_READ_ERR, &eb->bflags);
        }
 
-       bio_for_each_folio_all(fi, &bbio->bio) {
-               struct folio *folio = fi.folio;
-               u64 start = eb->start + bio_offset;
-               u32 len = fi.length;
-
-               if (uptodate)
-                       btrfs_folio_set_uptodate(fs_info, folio, start, len);
-               else
-                       btrfs_folio_clear_uptodate(fs_info, folio, start, len);
-
-               bio_offset += len;
-       }
-
        clear_extent_buffer_reading(eb);
        free_extent_buffer(eb);