pgbench: Fix handling of socket errors during benchmark.

Previously socket errors such as invalid socket or socket wait method failures
during benchmark caused pgbench to exit with status 0. Instead, errors during
the run should result in exit status 2.

Back-patch to v12 where pgbench started reporting exit status.

Original complaint and patch by Hayato Kuroda.

Author: Yugo Nagata, Fabien COELHO
Reviewed-by: Kyotaro Horiguchi, Fujii Masao
Discussion: https://postgr.es/m/TYCPR01MB5870057375ACA8A73099C649F5349@TYCPR01MB5870.jpnprd01.prod.outlook.com

diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
index a9a929d12a20eea89317f7017b883114734cdf74..c5e028bd88dc148f96ccb1e3eaa42c94a4f96259 100644 (file)
--- a/src/bin/pgbench/pgbench.c
+++ b/src/bin/pgbench/pgbench.c
@@ -5863,7 +5863,7 @@ main(int argc, char **argv)
 #endif                                                 /* ENABLE_THREAD_SAFETY */
 
                for (int j = 0; j < thread->nstate; j++)
-                       if (thread->state[j].state == CSTATE_ABORTED)
+                       if (thread->state[j].state != CSTATE_FINISHED)
                                exit_code = 2;
 
                /* aggregate thread level stats */