]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
store: remove TODOs
authorPauli <pauli@openssl.org>
Mon, 31 May 2021 04:29:34 +0000 (14:29 +1000)
committerPauli <pauli@openssl.org>
Wed, 2 Jun 2021 06:30:15 +0000 (16:30 +1000)
Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/15539)

crypto/store/store_local.h
crypto/store/store_result.c

index 4d29857620d33dde36c4855cb504758a94bb45f3..6aeaaa915f3d4f2f443888c49edb0681b362bd1e 100644 (file)
@@ -54,7 +54,7 @@ struct ossl_store_search_st {
      * Used by OSSL_STORE_SEARCH_BY_NAME and
      * OSSL_STORE_SEARCH_BY_ISSUER_SERIAL
      */
-    X509_NAME *name; /* TODO constify this; leads to API incompatibility */
+    X509_NAME *name;
 
     /* Used by OSSL_STORE_SEARCH_BY_ISSUER_SERIAL */
     const ASN1_INTEGER *serial;
index c78d96d5321b04eb98a644b6abaa90374344739e..91c679718c58d407df83166e2331a82535a5d986 100644 (file)
@@ -399,8 +399,6 @@ static int try_key(struct extracted_param_data_st *data, OSSL_STORE_INFO **v,
              * engine provided legacy key.
              * This is the same as der2key_decode() does, but in a limited
              * way and within the walls of libcrypto.
-             *
-             * TODO Remove this when #legacy keys are gone
              */
             if (pk == NULL)
                 pk = try_key_value_legacy(data, &store_info_new, ctx,