]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
serial: qcom-geni: fix rx cancel dma status bit
authorJohan Hovold <johan+linaro@kernel.org>
Wed, 9 Oct 2024 14:51:07 +0000 (16:51 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 11 Oct 2024 06:39:23 +0000 (08:39 +0200)
Cancelling an rx command is signalled using bit 14 of the rx DMA status
register and not bit 11.

This bit is currently unused, but this error becomes apparent, for
example, when tracing the status register when closing the port.

Fixes: eddac5af0654 ("soc: qcom: Add GENI based QUP Wrapper driver")
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20241009145110.16847-7-johan+linaro@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/soc/qcom/geni-se.h

index c3bca9c0bf2cf52f96243b2e033213adb31adf95..2996a3c28ef3eb289ba9c3bd9a286e483bb0a997 100644 (file)
@@ -258,8 +258,8 @@ struct geni_se {
 #define RX_DMA_PARITY_ERR              BIT(5)
 #define RX_DMA_BREAK                   GENMASK(8, 7)
 #define RX_GENI_GP_IRQ                 GENMASK(10, 5)
-#define RX_GENI_CANCEL_IRQ             BIT(11)
 #define RX_GENI_GP_IRQ_EXT             GENMASK(13, 12)
+#define RX_GENI_CANCEL_IRQ             BIT(14)
 
 /* SE_HW_PARAM_0 fields */
 #define TX_FIFO_WIDTH_MSK              GENMASK(29, 24)