]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ASoC: rt-sdw-common: Enhance switch case to prevent uninitialized variable
authorJack Yu <jack.yu@realtek.com>
Mon, 14 Oct 2024 09:55:20 +0000 (09:55 +0000)
committerMark Brown <broonie@kernel.org>
Mon, 14 Oct 2024 11:45:20 +0000 (12:45 +0100)
If det_mode is not 0, 3 or 5 then function will return
jack_type with an uninitialzed value.
Enhance switch case to prevent uninitialized variable issue.

Signed-off-by: Jack Yu <jack.yu@realtek.com>
Link: https://patch.msgid.link/8631337239d744088d56caab2d8f39cb@realtek.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt-sdw-common.c

index a422da6cf7026781afd4bb9c1b6df61b194d5e57..9f51fec383f9b30469bf72f45c6833c1614e2d10 100644 (file)
@@ -150,15 +150,15 @@ int rt_sdca_headset_detect(struct regmap *map, unsigned int entity_id)
                goto io_error;
 
        switch (det_mode) {
-       case 0x00:
-               jack_type = 0;
-               break;
        case 0x03:
                jack_type = SND_JACK_HEADPHONE;
                break;
        case 0x05:
                jack_type = SND_JACK_HEADSET;
                break;
+       default:
+               jack_type = 0;
+               break;
        }
 
        /* write selected_mode */