media: i2c: hi556: Use V4L2 sensor clock helper

Several camera sensor drivers access the "clock-frequency" property
directly to retrieve the external clock rate, or modify the clock rate
of the external clock programmatically. Both behaviours are valid on
a subset of ACPI platforms, but are considered deprecated on OF
platforms, and do not support ACPI platforms that implement MIPI DisCo
for Imaging. Implementing them manually in drivers is deprecated, as
that can encourage cargo-cult and lead to differences in behaviour
between drivers. Instead, drivers should use the
devm_v4l2_sensor_clk_get() helper.

This driver supports ACPI platforms only. It retrieves the clock if
present, and retrieves the clock rate from the "clock-frequency"
property. If the rate does not match the expected rate, the driver fails
probing. This is correct behaviour for ACPI.

Switch to using the devm_v4l2_sensor_clk_get() helper. This does not
change the behaviour on ACPI platforms that specify a clock-frequency
property and don't provide a clock. On ACPI platforms that provide a
clock, the clock rate will be set to the value of the clock-frequency
property. This should not change the behaviour either as this driver
expects the clock to be set to that rate, and wouldn't operate correctly
otherwise.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

diff --git a/drivers/media/i2c/hi556.c b/drivers/media/i2c/hi556.c
index cd7c3e4fd39c0da82ad4c35e54c3d1f7e71d70e9..de573cee44510e864f449842d7b23e77b43430c2 100644 (file)
--- a/drivers/media/i2c/hi556.c
+++ b/drivers/media/i2c/hi556.c
@@ -1213,7 +1213,6 @@ static int hi556_check_hwcfg(struct device *dev)
        struct v4l2_fwnode_endpoint bus_cfg = {
                .bus_type = V4L2_MBUS_CSI2_DPHY
        };
-       u32 mclk;
        int ret = 0;
        unsigned int i, j;
 
@@ -1231,18 +1230,6 @@ static int hi556_check_hwcfg(struct device *dev)
        if (ret)
                return dev_err_probe(dev, ret, "parsing endpoint failed\n");
 
-       ret = fwnode_property_read_u32(fwnode, "clock-frequency", &mclk);
-       if (ret) {
-               dev_err(dev, "can't get clock frequency\n");
-               goto check_hwcfg_error;
-       }
-
-       if (mclk != HI556_MCLK) {
-               dev_err(dev, "external clock %d is not supported\n", mclk);
-               ret = -EINVAL;
-               goto check_hwcfg_error;
-       }
-
        if (bus_cfg.bus.mipi_csi2.num_data_lanes != 2) {
                dev_err(dev, "number of CSI2 data lanes %d is not supported\n",
                        bus_cfg.bus.mipi_csi2.num_data_lanes);
@@ -1332,6 +1319,7 @@ static int hi556_resume(struct device *dev)
 static int hi556_probe(struct i2c_client *client)
 {
        struct hi556 *hi556;
+       unsigned long freq;
        bool full_power;
        int i, ret;
 
@@ -1353,11 +1341,17 @@ static int hi556_probe(struct i2c_client *client)
                return dev_err_probe(hi556->dev, PTR_ERR(hi556->reset_gpio),
                                     "failed to get reset GPIO\n");
 
-       hi556->clk = devm_clk_get_optional(hi556->dev, "clk");
+       hi556->clk = devm_v4l2_sensor_clk_get(hi556->dev, "clk");
        if (IS_ERR(hi556->clk))
                return dev_err_probe(hi556->dev, PTR_ERR(hi556->clk),
                                     "failed to get clock\n");
 
+       freq = clk_get_rate(hi556->clk);
+       if (freq != HI556_MCLK)
+               return dev_err_probe(hi556->dev, -EINVAL,
+                                    "external clock %lu is not supported\n",
+                                    freq);
+
        for (i = 0; i < ARRAY_SIZE(hi556_supply_names); i++)
                hi556->supplies[i].supply = hi556_supply_names[i];