auth: fix catalogDiff() coverity report

(cherry picked from commit ba2642a7f2c85246764c263679470aeb04577175)

diff --git a/pdns/slavecommunicator.cc b/pdns/slavecommunicator.cc
index fcb47be130f54cdf9e5dfa082252f1251e81ef0c..d8ccff1388fc92bfaecacafb6814b25dc01c3266 100644 (file)
--- a/pdns/slavecommunicator.cc
+++ b/pdns/slavecommunicator.cc
@@ -108,12 +108,12 @@ static bool catalogDiff(const DomainInfo& di, vector<CatalogInfo>& fromXFR, vect
       bool create{false};
       bool remove{false};
 
-      if ((xfr != fromXFR.end() && db == fromDB.end()) || *xfr < *db) { // create
+      if (xfr != fromXFR.end() && (db == fromDB.end() || *xfr < *db)) { // create
         ciCreate = *xfr;
         create = true;
         ++xfr;
       }
-      else if ((db != fromDB.end() && xfr == fromXFR.end()) || *db < *xfr) { // remove
+      else if (db != fromDB.end() && (xfr == fromXFR.end() || *db < *xfr)) { // remove
         ciRemove = *db;
         remove = true;
         ++db;