]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/bridge: cdns-dsi: Check return value when getting default PHY config
authorAradhya Bhatia <a-bhatia1@ti.com>
Sat, 29 Mar 2025 11:39:15 +0000 (17:09 +0530)
committerDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Sun, 30 Mar 2025 16:47:12 +0000 (19:47 +0300)
Check for the return value of the phy_mipi_dphy_get_default_config()
call, and in case of an error, return back the same.

Fixes: fced5a364dee ("drm/bridge: cdns: Convert to phy framework")
Cc: stable@vger.kernel.org
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Tested-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com>
Signed-off-by: Aradhya Bhatia <aradhya.bhatia@linux.dev>
Link: https://lore.kernel.org/r/20250329113925.68204-5-aradhya.bhatia@linux.dev
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c

index 02613ba7a05b7026343e497c154fe802627b55e5..741d676b8266730b01e9a2b0ea8b9217fbddf2d0 100644 (file)
@@ -575,9 +575,11 @@ static int cdns_dsi_check_conf(struct cdns_dsi *dsi,
        if (ret)
                return ret;
 
-       phy_mipi_dphy_get_default_config(mode_clock * 1000,
-                                        mipi_dsi_pixel_format_to_bpp(output->dev->format),
-                                        nlanes, phy_cfg);
+       ret = phy_mipi_dphy_get_default_config(mode_clock * 1000,
+                                              mipi_dsi_pixel_format_to_bpp(output->dev->format),
+                                              nlanes, phy_cfg);
+       if (ret)
+               return ret;
 
        ret = cdns_dsi_adjust_phy_config(dsi, dsi_cfg, phy_cfg, mode, mode_valid_check);
        if (ret)