]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Add missing valgrind supressions
authorNeil Horman <nhorman@openssl.org>
Wed, 11 Feb 2026 17:44:35 +0000 (12:44 -0500)
committerNeil Horman <nhorman@openssl.org>
Tue, 24 Feb 2026 15:11:11 +0000 (10:11 -0500)
Running valgrind in CI triggered a few errors that local testing missed,
add those to the suppression file

Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Norbert Pocs <norbertp@openssl.org>
MergeDate: Tue Feb 24 15:11:14 2026
(Merged from https://github.com/openssl/openssl/pull/30003)

util/perl/OpenSSL/Test.pm
util/valgrind.suppression

index 529f4e4c5281222d309f6941bd91824f4560f5a3..1034533251a38980026d6a92391a2ef719fe65dc 100644 (file)
@@ -333,7 +333,7 @@ sub app {
             $idx=$idx+1;
             my $resultdir = result_dir();
             my $srcdir = srctop_dir();
-            return cmd([ "valgrind", "--leak-check=full", "--show-leak-kinds=all", "--gen-suppressions=all", "--log-file=$resultdir/valgrind.log.$idx", "--suppressions=$srcdir/util/valgrind.suppression", @prog, @cmdargs ],
+            return cmd([ "valgrind", "--leak-check=full", "--show-leak-kinds=all", "--gen-suppressions=all", "--suppressions=$srcdir/util/valgrind.suppression", "--log-file=$resultdir/valgrind.log.$idx", "--suppressions=$srcdir/util/valgrind.suppression", @prog, @cmdargs ],
                        exe_shell => $ENV{EXE_SHELL}, %opts) -> (shift);
         } else {
             return cmd([ @prog, @cmdargs ],
@@ -363,7 +363,7 @@ sub test {
            $idx=$idx+1;
            my $resultdir = result_dir();
            my $srcdir = srctop_dir();
-           return cmd([ "valgrind", "--leak-check=full", "--show-leak-kinds=all", "--gen-suppressions=all", "--log-file=$resultdir/valgrind.log.$idx", "--suppressions=$srcdir/util/valgrind.suppression", @prog, @cmdargs ],
+           return cmd([ "valgrind", "--leak-check=full", "--show-leak-kinds=all", "--gen-suppressions=all", "--suppressions=$srcdir/util/valgrind.suppression", "--log-file=$resultdir/valgrind.log.$idx", "--suppressions=$srcdir/util/valgrind.suppression", @prog, @cmdargs ],
                    exe_shell => $ENV{EXE_SHELL}, %opts) -> (shift);
         } else {
             return cmd([ @prog, @cmdargs ],
index f34fce467216bcf03af924db59e8c5d781560801..4514e702b030060e8dac13c8b3dce8dd21c5e57a 100644 (file)
    fun:ssl_release_record
    ...
 }
+{
+   provider_activate_strdup 
+   Memcheck:Leak
+   match-leak-kinds: reachable
+   fun:malloc
+   ...
+   fun:OSSL_provider_init
+   fun:provider_activate
+   ...
+}
+{
+   false_positive_conditional_check
+   Memcheck:Cond
+   fun:bcmp
+   fun:test_mem_eq
+   ...
+}
+{
+   false_positive_conditional_check
+   Memcheck:Cond
+   fun:ossl_gcm_stream_final
+   ...
+}
+{
+   false_positive_conditional_check
+   Memcheck:Cond
+   fun:gcm_cipher_internal
+   ...
+}