]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/amd/display: Add NULL check within get_target_mpc_factor
authorHersen Wu <hersenxs.wu@amd.com>
Fri, 26 Apr 2024 15:24:21 +0000 (11:24 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 20 May 2024 20:20:24 +0000 (16:20 -0400)
[Why] Coverity reports NULL_RETURN warning.

[How] Add pointer NULL check.

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Signed-off-by: Hersen Wu <hersenxs.wu@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dml2/dml2_dc_resource_mgmt.c

index 190fa2962271af7fbad5083b1a2275444e980f8b..02fb2cb1c43c0ecbbb73a7f8486b07c9b1fa69cd 100644 (file)
@@ -819,7 +819,16 @@ static unsigned int get_target_mpc_factor(struct dml2_context *ctx,
 
                        /* get stream id of main stream */
                        main_stream = ctx->config.svp_pstate.callbacks.get_paired_subvp_stream(state, stream);
+                       if (!main_stream) {
+                               ASSERT(false);
+                               return 1;
+                       }
+
                        main_stream_status = ctx->config.callbacks.get_stream_status(state, main_stream);
+                       if (!main_stream_status) {
+                               ASSERT(false);
+                               return 1;
+                       }
 
                        /* get plane id for associated main plane */
                        get_plane_id(ctx, state, main_stream_status->plane_states[plane_idx],