]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib-master: master_service_import_environment() - use a data stack frame
authorTimo Sirainen <timo.sirainen@dovecot.fi>
Wed, 7 Jun 2017 21:33:32 +0000 (00:33 +0300)
committerGitLab <gitlab@git.dovecot.net>
Sat, 10 Jun 2017 08:35:40 +0000 (11:35 +0300)
This way the caller doesn't have to do it.

src/lib-master/master-service.c
src/master/main.c

index ff63d5309e0abd52daa7f3eb7e06e270aa97c338..ccea53157664af4d5361c333780cdd5b0447406f 100644 (file)
@@ -566,7 +566,7 @@ void master_service_init_finish(struct master_service *service)
        }
 }
 
-void master_service_import_environment(const char *import_environment)
+static void master_service_import_environment_real(const char *import_environment)
 {
        const char *const *envs, *key, *value;
        ARRAY_TYPE(const_string) keys;
@@ -597,6 +597,13 @@ void master_service_import_environment(const char *import_environment)
        env_put(t_strconcat(DOVECOT_PRESERVE_ENVS_ENV"=", value, NULL));
 }
 
+void master_service_import_environment(const char *import_environment)
+{
+       T_BEGIN {
+               master_service_import_environment_real(import_environment);
+       } T_END;
+}
+
 void master_service_env_clean(void)
 {
        const char *value = getenv(DOVECOT_PRESERVE_ENVS_ENV);
index c7c974e16c1319d95af8bcf53f4b5143dd01bc05..493ddd796a740e65c688f7e713be7abdddb26527 100644 (file)
@@ -819,11 +819,9 @@ int main(int argc, char *argv[])
        master_settings_do_fixes(set);
        fatal_log_check(set);
 
-       T_BEGIN {
-               const struct master_service_settings *service_set =
-                       master_service_settings_get(master_service);
-               master_service_import_environment(service_set->import_environment);
-       } T_END;
+       const struct master_service_settings *service_set =
+               master_service_settings_get(master_service);
+       master_service_import_environment(service_set->import_environment);
        master_service_env_clean();
 
        /* create service structures from settings. if there are any errors in