]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
riscv: cpufeature: use bitmap_equal() instead of memcmp()
authorClément Léger <cleger@rivosinc.com>
Mon, 10 Feb 2025 15:56:14 +0000 (16:56 +0100)
committerPalmer Dabbelt <palmer@rivosinc.com>
Fri, 14 Feb 2025 21:06:16 +0000 (13:06 -0800)
Comparison of bitmaps should be done using bitmap_equal(), not memcmp(),
use the former one to compare isa bitmaps.

Signed-off-by: Clément Léger <cleger@rivosinc.com>
Fixes: 625034abd52a8c ("riscv: add ISA extensions validation callback")
Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20250210155615.1545738-1-cleger@rivosinc.com
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
arch/riscv/kernel/cpufeature.c

index c6ba750536c3262af505052e121726310325c621..40ac72e407b685fe76dc094f716b725006c22bd8 100644 (file)
@@ -479,7 +479,7 @@ static void __init riscv_resolve_isa(unsigned long *source_isa,
                        if (bit < RISCV_ISA_EXT_BASE)
                                *this_hwcap |= isa2hwcap[bit];
                }
-       } while (loop && memcmp(prev_resolved_isa, resolved_isa, sizeof(prev_resolved_isa)));
+       } while (loop && !bitmap_equal(prev_resolved_isa, resolved_isa, RISCV_ISA_EXT_MAX));
 }
 
 static void __init match_isa_ext(const char *name, const char *name_end, unsigned long *bitmap)