]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
nfc: pn533: Delete an unnecessary check
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 13 Aug 2025 05:51:22 +0000 (08:51 +0300)
committerJakub Kicinski <kuba@kernel.org>
Fri, 15 Aug 2025 00:33:20 +0000 (17:33 -0700)
The "rc" variable is set like this:

if (IS_ERR(resp)) {
rc = PTR_ERR(resp);

We know that "rc" is negative so there is no need to check.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://patch.msgid.link/aJwn2ox5g9WsD2Vx@stanley.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/nfc/pn533/pn533.c

index 14661249c690281a406d8ae0fa7f3382bf55316f..2b043a9f9533eb2659f6a2f4f0d4aa47079b8ee0 100644 (file)
@@ -1412,11 +1412,9 @@ static int pn533_autopoll_complete(struct pn533 *dev, void *arg,
                        if (dev->poll_mod_count != 0)
                                return rc;
                        goto stop_poll;
-               } else if (rc < 0) {
-                       nfc_err(dev->dev,
-                               "Error %d when running autopoll\n", rc);
-                       goto stop_poll;
                }
+               nfc_err(dev->dev, "Error %d when running autopoll\n", rc);
+               goto stop_poll;
        }
 
        nbtg = resp->data[0];
@@ -1505,11 +1503,9 @@ static int pn533_poll_complete(struct pn533 *dev, void *arg,
                        if (dev->poll_mod_count != 0)
                                return rc;
                        goto stop_poll;
-               } else if (rc < 0) {
-                       nfc_err(dev->dev,
-                               "Error %d when running poll\n", rc);
-                       goto stop_poll;
                }
+               nfc_err(dev->dev, "Error %d when running poll\n", rc);
+               goto stop_poll;
        }
 
        cur_mod = dev->poll_mod_active[dev->poll_mod_curr];