]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
usb: typec: qcom: set pm8150b_typec_res storage-class-specifier to static
authorTom Rix <trix@redhat.com>
Mon, 15 May 2023 11:40:43 +0000 (07:40 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 29 May 2023 14:17:21 +0000 (15:17 +0100)
smatch reports
drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c:323:29: warning: symbol
  'pm8150b_typec_res' was not declared. Should it be static?

This variable is only used in its defining file, so it should be static

Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20230515114043.3452010-1-trix@redhat.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c

index 191458ce4a069b1fdecb15d718126e097db35612..937e855a6c4c311bc45ae511d78dc375dd10e4ae 100644 (file)
@@ -320,7 +320,7 @@ static struct pmic_typec_port_resources pm8150b_port_res = {
        .nr_irqs = 7,
 };
 
-struct pmic_typec_resources pm8150b_typec_res = {
+static struct pmic_typec_resources pm8150b_typec_res = {
        .pdphy_res = &pm8150b_pdphy_res,
        .port_res = &pm8150b_port_res,
 };