- Fix a memory leak in FwdState::sslCrtvdCheckForErrors method: The allocated

  ACLFilledChecklist object should released before leave this method
polish code a little:
   * debuging messages fix
   * Fix debug section in ssl/helper.cc file

diff --git a/src/forward.cc b/src/forward.cc
index a17daf14de0c70100fe3c8f8f237f75691c8e01d..638bdbc68a983b6e56c019655b33ce9df17bc681 100644 (file)
--- a/src/forward.cc
+++ b/src/forward.cc
@@ -826,7 +826,7 @@ FwdState::sslCrtvdHandleReply(const char *reply)
     SSL *ssl = fd_table[serverConnection()->fd].ssl;
 
     if (!reply) {
-        debugs(83, 1, HERE << "\"ssl_crtd\" helper return <NULL> reply");
+        debugs(83, 1, HERE << "\"ssl_crtvd\" helper return <NULL> reply");
         validatorFailed = true;
     } else {
         Ssl::CertValidationMsg replyMsg;
@@ -936,6 +936,8 @@ FwdState::sslCrtvdCheckForErrors(Ssl::CertValidationResponse &resp, Ssl::ErrorDe
         else
             errs->push_back_unique(i->error_no);
     }
+    if (check)
+        delete check;
 
     return errs;
 }

diff --git a/src/ssl/helper.cc b/src/ssl/helper.cc
index 48459f73b2ea8f4c4cea5e25f75c5886c68ed296..d42db1c7304a68ae49376f72383233fb9f8cdc84 100644 (file)
--- a/src/ssl/helper.cc
+++ b/src/ssl/helper.cc
@@ -178,7 +178,7 @@ void Ssl::CertValidationHelper::sslSubmit(CrtdMessage const & message, HLPCB * c
             first_warn = squid_curtime;
         if (squid_curtime - first_warn > 3 * 60)
             fatal("SSL servers not responding for 3 minutes");
-        debugs(34, 1, HERE << "Queue overload, rejecting");
+        debugs(83, 1, HERE << "Queue overload, rejecting");
         callback(data, (char *)"error 45 Temporary network problem, please retry later");
         return;
     }