[#3860] addressed review

diff --git a/src/hooks/dhcp/radius/client_attribute.cc b/src/hooks/dhcp/radius/client_attribute.cc
index 5e3b1118a1c0adab074f70d2dfc62390e44508ff..4e33ee680afc9e8f13988d385383b76985b52957 100644 (file)
--- a/src/hooks/dhcp/radius/client_attribute.cc
+++ b/src/hooks/dhcp/radius/client_attribute.cc
@@ -301,7 +301,9 @@ AttrString::toBytes() const {
     output.resize(2 + getValueLen());
     output[0] = getType();
     output[1] = 2 + getValueLen();
-    memmove(&output[2], &value_[0], output.size() - 2);
+    if (output.size() > 2) {
+        memmove(&output[2], &value_[0], output.size() - 2);
+    }
     return (output);
 }
 

diff --git a/src/hooks/dhcp/radius/data/dictionary b/src/hooks/dhcp/radius/data/dictionary
index 94ed4716bcfc8ef7ec9e1081fc176df151c448e3..f81920b106c1fa5a543d9c9fdef1db5bdc0aabc8 100644 (file)
--- a/src/hooks/dhcp/radius/data/dictionary
+++ b/src/hooks/dhcp/radius/data/dictionary
@@ -257,3 +257,7 @@ VALUE           Acct-Terminate-Cause    Host-Request            18
 
 #$INCLUDE      foobar
 #VENDOR                DSL-Forum               3561
+#BEGIN-VENDOR  DSL-Forum
+#ATTRIBUTE     Agent-Circuit-Id        1       string
+#END-VENDOR    DSL-Forum
+