]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
RDMA/mlx5: Consider the query_vuid cap for data_direct
authorYishai Hadas <yishaih@nvidia.com>
Mon, 9 Sep 2024 18:47:33 +0000 (21:47 +0300)
committerLeon Romanovsky <leon@kernel.org>
Fri, 13 Sep 2024 05:27:40 +0000 (08:27 +0300)
Consider also the query_vuid cap before enabling the data_direct
functionality.

This may prevent a syndrome from the FW in case the query_vuid command
is not supported. (e.g. migratable VF)

Signed-off-by: Yishai Hadas <yishaih@nvidia.com>
Reviewed-by: Gal Shalom <galshalom@nvidia.com>
Link: https://patch.msgid.link/274c4f6f1ac0b1078243dd296695a49dbe58e7d1.1725907637.git.leonro@nvidia.com
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/hw/mlx5/main.c

index b85ad3c0bfa1a67c0881805d86c4f0a72156362a..af9ccae684babc927ebf6e16fcae73814eab7467 100644 (file)
@@ -3479,7 +3479,8 @@ static int mlx5_ib_data_direct_init(struct mlx5_ib_dev *dev)
        char vuid[MLX5_ST_SZ_BYTES(array1024_auto) + 1] = {};
        int ret;
 
-       if (!MLX5_CAP_GEN(dev->mdev, data_direct))
+       if (!MLX5_CAP_GEN(dev->mdev, data_direct) ||
+           !MLX5_CAP_GEN_2(dev->mdev, query_vuid))
                return 0;
 
        ret = mlx5_cmd_query_vuid(dev->mdev, true, vuid);
@@ -3500,7 +3501,8 @@ static int mlx5_ib_data_direct_init(struct mlx5_ib_dev *dev)
 
 static void mlx5_ib_data_direct_cleanup(struct mlx5_ib_dev *dev)
 {
-       if (!MLX5_CAP_GEN(dev->mdev, data_direct))
+       if (!MLX5_CAP_GEN(dev->mdev, data_direct) ||
+           !MLX5_CAP_GEN_2(dev->mdev, query_vuid))
                return;
 
        mlx5_data_direct_ib_unreg(dev);