]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
misc: microchip: pci1xxxx: Resolve return code mismatch during GPIO set config
authorRengarajan S <rengarajan.s@microchip.com>
Thu, 5 Dec 2024 13:36:26 +0000 (19:06 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 Jan 2025 14:47:39 +0000 (15:47 +0100)
Driver returns -EOPNOTSUPPORTED on unsupported parameters case in set
config. Upper level driver checks for -ENOTSUPP. Because of the return
code mismatch, the ioctls from userspace fail. Resolve the issue by
passing -ENOTSUPP during unsupported case.

Fixes: 7d3e4d807df2 ("misc: microchip: pci1xxxx: load gpio driver for the gpio controller auxiliary device enumerated by the auxiliary bus driver.")
Cc: stable <stable@kernel.org>
Signed-off-by: Rengarajan S <rengarajan.s@microchip.com>
Link: https://lore.kernel.org/r/20241205133626.1483499-3-rengarajan.s@microchip.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c

index 558290bdb938cab4709b86ef49528f1f92f076ec..3c1359d8d4e6926733e0b45c13e6462d09fc798a 100644 (file)
@@ -148,7 +148,7 @@ static int pci1xxxx_gpio_set_config(struct gpio_chip *gpio, unsigned int offset,
                pci1xxx_assign_bit(priv->reg_base, OPENDRAIN_OFFSET(offset), (offset % 32), true);
                break;
        default:
-               ret = -EOPNOTSUPP;
+               ret = -ENOTSUPP;
                break;
        }
        spin_unlock_irqrestore(&priv->lock, flags);