]> git.ipfire.org Git - thirdparty/git.git/commitdiff
tree-walk: rename "error" variable
authorJeff King <peff@peff.net>
Thu, 31 Aug 2023 06:19:22 +0000 (02:19 -0400)
committerJunio C Hamano <gitster@pobox.com>
Thu, 31 Aug 2023 22:51:07 +0000 (15:51 -0700)
The "error" variable in traverse_trees() shadows the global error()
function (meaning we can't call error() from here). Let's call the local
variable "ret" instead, which matches the idiom in other functions.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
tree-walk.c

index ad49d552901d25e8763446c80e076ef33c00fad2..4efd0fc391d188361e9855071d29d7a335aad01a 100644 (file)
@@ -441,7 +441,7 @@ int traverse_trees(struct index_state *istate,
                   int n, struct tree_desc *t,
                   struct traverse_info *info)
 {
-       int error = 0;
+       int ret = 0;
        struct name_entry *entry;
        int i;
        struct tree_desc_x *tx;
@@ -539,7 +539,7 @@ int traverse_trees(struct index_state *istate,
                if (interesting) {
                        trees_used = info->fn(n, mask, dirmask, entry, info);
                        if (trees_used < 0) {
-                               error = trees_used;
+                               ret = trees_used;
                                if (!info->show_all_errors)
                                        break;
                        }
@@ -558,7 +558,7 @@ int traverse_trees(struct index_state *istate,
        strbuf_release(&base);
 
        traverse_trees_cur_depth--;
-       return error;
+       return ret;
 }
 
 struct dir_state {