scsi: target: sbp_target: Convert to new submission API

target_submit_cmd() is now only for simple drivers that do their own sync
during shutdown and do not use target_stop_session(). It will never return
a failure, so we can remove that code from the driver.

Link: https://lore.kernel.org/r/20210227170006.5077-10-michael.christie@oracle.com
Cc: Chris Boot <bootc@bootc.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/target/sbp/sbp_target.c b/drivers/target/sbp/sbp_target.c
index 2a6165febd3b117812cf771b79e8a0837099265e..ce84f93c183a01ef23cb6eeba3ee219d3959e713 100644 (file)
--- a/drivers/target/sbp/sbp_target.c
+++ b/drivers/target/sbp/sbp_target.c
@@ -1218,11 +1218,9 @@ static void sbp_handle_command(struct sbp_target_request *req)
 
        /* only used for printk until we do TMRs */
        req->se_cmd.tag = req->orb_pointer;
-       if (target_submit_cmd(&req->se_cmd, sess->se_sess, req->cmd_buf,
-                             req->sense_buf, unpacked_lun, data_length,
-                             TCM_SIMPLE_TAG, data_dir, TARGET_SCF_ACK_KREF))
-               goto err;
-
+       target_submit_cmd(&req->se_cmd, sess->se_sess, req->cmd_buf,
+                         req->sense_buf, unpacked_lun, data_length,
+                         TCM_SIMPLE_TAG, data_dir, TARGET_SCF_ACK_KREF);
        return;
 
 err: