--- /dev/null
+From 754e4382354f7908923a1949d8dc8d05f82f09cb Mon Sep 17 00:00:00 2001
+From: Pavel Skripkin <paskripkin@gmail.com>
+Date: Tue, 4 Jan 2022 21:28:06 +0300
+Subject: ieee802154: atusb: fix uninit value in atusb_set_extended_addr
+
+From: Pavel Skripkin <paskripkin@gmail.com>
+
+commit 754e4382354f7908923a1949d8dc8d05f82f09cb upstream.
+
+Alexander reported a use of uninitialized value in
+atusb_set_extended_addr(), that is caused by reading 0 bytes via
+usb_control_msg().
+
+Fix it by validating if the number of bytes transferred is actually
+correct, since usb_control_msg() may read less bytes, than was requested
+by caller.
+
+Fail log:
+
+BUG: KASAN: uninit-cmp in ieee802154_is_valid_extended_unicast_addr include/linux/ieee802154.h:310 [inline]
+BUG: KASAN: uninit-cmp in atusb_set_extended_addr drivers/net/ieee802154/atusb.c:1000 [inline]
+BUG: KASAN: uninit-cmp in atusb_probe.cold+0x29f/0x14db drivers/net/ieee802154/atusb.c:1056
+Uninit value used in comparison: 311daa649a2003bd stack handle: 000000009a2003bd
+ ieee802154_is_valid_extended_unicast_addr include/linux/ieee802154.h:310 [inline]
+ atusb_set_extended_addr drivers/net/ieee802154/atusb.c:1000 [inline]
+ atusb_probe.cold+0x29f/0x14db drivers/net/ieee802154/atusb.c:1056
+ usb_probe_interface+0x314/0x7f0 drivers/usb/core/driver.c:396
+
+Fixes: 7490b008d123 ("ieee802154: add support for atusb transceiver")
+Reported-by: Alexander Potapenko <glider@google.com>
+Acked-by: Alexander Aring <aahringo@redhat.com>
+Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
+Link: https://lore.kernel.org/r/20220104182806.7188-1-paskripkin@gmail.com
+Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/net/ieee802154/atusb.c | 10 ++++++----
+ 1 file changed, 6 insertions(+), 4 deletions(-)
+
+--- a/drivers/net/ieee802154/atusb.c
++++ b/drivers/net/ieee802154/atusb.c
+@@ -93,7 +93,9 @@ static int atusb_control_msg(struct atus
+
+ ret = usb_control_msg(usb_dev, pipe, request, requesttype,
+ value, index, data, size, timeout);
+- if (ret < 0) {
++ if (ret < size) {
++ ret = ret < 0 ? ret : -ENODATA;
++
+ atusb->err = ret;
+ dev_err(&usb_dev->dev,
+ "%s: req 0x%02x val 0x%x idx 0x%x, error %d\n",
+@@ -861,9 +863,9 @@ static int atusb_get_and_show_build(stru
+ if (!build)
+ return -ENOMEM;
+
+- ret = atusb_control_msg(atusb, usb_rcvctrlpipe(usb_dev, 0),
+- ATUSB_BUILD, ATUSB_REQ_FROM_DEV, 0, 0,
+- build, ATUSB_BUILD_SIZE, 1000);
++ /* We cannot call atusb_control_msg() here, since this request may read various length data */
++ ret = usb_control_msg(atusb->usb_dev, usb_rcvctrlpipe(usb_dev, 0), ATUSB_BUILD,
++ ATUSB_REQ_FROM_DEV, 0, 0, build, ATUSB_BUILD_SIZE, 1000);
+ if (ret >= 0) {
+ build[ret] = 0;
+ dev_info(&usb_dev->dev, "Firmware: build %s\n", build);
f2fs-quota-fix-potential-deadlock.patch
selftests-x86-fix-warn-in-test_process_vm_readv.patch
+tracing-fix-check-for-trace_percpu_buffer-validity-in-get_trace_buf.patch
+tracing-tag-trace_percpu_buffer-as-a-percpu-pointer.patch
+ieee802154-atusb-fix-uninit-value-in-atusb_set_extended_addr.patch
--- /dev/null
+From 823e670f7ed616d0ce993075c8afe0217885f79d Mon Sep 17 00:00:00 2001
+From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
+Date: Thu, 23 Dec 2021 16:04:38 +0530
+Subject: tracing: Fix check for trace_percpu_buffer validity in get_trace_buf()
+
+From: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
+
+commit 823e670f7ed616d0ce993075c8afe0217885f79d upstream.
+
+With the new osnoise tracer, we are seeing the below splat:
+ Kernel attempted to read user page (c7d880000) - exploit attempt? (uid: 0)
+ BUG: Unable to handle kernel data access on read at 0xc7d880000
+ Faulting instruction address: 0xc0000000002ffa10
+ Oops: Kernel access of bad area, sig: 11 [#1]
+ LE PAGE_SIZE=64K MMU=Radix SMP NR_CPUS=2048 NUMA pSeries
+ ...
+ NIP [c0000000002ffa10] __trace_array_vprintk.part.0+0x70/0x2f0
+ LR [c0000000002ff9fc] __trace_array_vprintk.part.0+0x5c/0x2f0
+ Call Trace:
+ [c0000008bdd73b80] [c0000000001c49cc] put_prev_task_fair+0x3c/0x60 (unreliable)
+ [c0000008bdd73be0] [c000000000301430] trace_array_printk_buf+0x70/0x90
+ [c0000008bdd73c00] [c0000000003178b0] trace_sched_switch_callback+0x250/0x290
+ [c0000008bdd73c90] [c000000000e70d60] __schedule+0x410/0x710
+ [c0000008bdd73d40] [c000000000e710c0] schedule+0x60/0x130
+ [c0000008bdd73d70] [c000000000030614] interrupt_exit_user_prepare_main+0x264/0x270
+ [c0000008bdd73de0] [c000000000030a70] syscall_exit_prepare+0x150/0x180
+ [c0000008bdd73e10] [c00000000000c174] system_call_vectored_common+0xf4/0x278
+
+osnoise tracer on ppc64le is triggering osnoise_taint() for negative
+duration in get_int_safe_duration() called from
+trace_sched_switch_callback()->thread_exit().
+
+The problem though is that the check for a valid trace_percpu_buffer is
+incorrect in get_trace_buf(). The check is being done after calculating
+the pointer for the current cpu, rather than on the main percpu pointer.
+Fix the check to be against trace_percpu_buffer.
+
+Link: https://lkml.kernel.org/r/a920e4272e0b0635cf20c444707cbce1b2c8973d.1640255304.git.naveen.n.rao@linux.vnet.ibm.com
+
+Cc: stable@vger.kernel.org
+Fixes: e2ace001176dc9 ("tracing: Choose static tp_printk buffer by explicit nesting count")
+Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
+Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ kernel/trace/trace.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/kernel/trace/trace.c
++++ b/kernel/trace/trace.c
+@@ -3144,7 +3144,7 @@ static char *get_trace_buf(void)
+ {
+ struct trace_buffer_struct *buffer = this_cpu_ptr(trace_percpu_buffer);
+
+- if (!buffer || buffer->nesting >= 4)
++ if (!trace_percpu_buffer || buffer->nesting >= 4)
+ return NULL;
+
+ buffer->nesting++;
--- /dev/null
+From f28439db470cca8b6b082239314e9fd10bd39034 Mon Sep 17 00:00:00 2001
+From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
+Date: Thu, 23 Dec 2021 16:04:39 +0530
+Subject: tracing: Tag trace_percpu_buffer as a percpu pointer
+
+From: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
+
+commit f28439db470cca8b6b082239314e9fd10bd39034 upstream.
+
+Tag trace_percpu_buffer as a percpu pointer to resolve warnings
+reported by sparse:
+ /linux/kernel/trace/trace.c:3218:46: warning: incorrect type in initializer (different address spaces)
+ /linux/kernel/trace/trace.c:3218:46: expected void const [noderef] __percpu *__vpp_verify
+ /linux/kernel/trace/trace.c:3218:46: got struct trace_buffer_struct *
+ /linux/kernel/trace/trace.c:3234:9: warning: incorrect type in initializer (different address spaces)
+ /linux/kernel/trace/trace.c:3234:9: expected void const [noderef] __percpu *__vpp_verify
+ /linux/kernel/trace/trace.c:3234:9: got int *
+
+Link: https://lkml.kernel.org/r/ebabd3f23101d89cb75671b68b6f819f5edc830b.1640255304.git.naveen.n.rao@linux.vnet.ibm.com
+
+Cc: stable@vger.kernel.org
+Reported-by: kernel test robot <lkp@intel.com>
+Fixes: 07d777fe8c398 ("tracing: Add percpu buffers for trace_printk()")
+Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
+Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ kernel/trace/trace.c | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+--- a/kernel/trace/trace.c
++++ b/kernel/trace/trace.c
+@@ -3134,7 +3134,7 @@ struct trace_buffer_struct {
+ char buffer[4][TRACE_BUF_SIZE];
+ };
+
+-static struct trace_buffer_struct *trace_percpu_buffer;
++static struct trace_buffer_struct __percpu *trace_percpu_buffer;
+
+ /*
+ * Thise allows for lockless recording. If we're nested too deeply, then
+@@ -3163,7 +3163,7 @@ static void put_trace_buf(void)
+
+ static int alloc_percpu_trace_buffer(void)
+ {
+- struct trace_buffer_struct *buffers;
++ struct trace_buffer_struct __percpu *buffers;
+
+ if (trace_percpu_buffer)
+ return 0;
projects / thirdparty / kernel / stable-queue.git / commitdiff
