]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/exynos: vidi: fix a wrong error return
authorInki Dae <inki.dae@samsung.com>
Thu, 18 May 2023 23:55:05 +0000 (08:55 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Jun 2023 08:18:41 +0000 (10:18 +0200)
[ Upstream commit 4a059559809fd1ddbf16f847c4d2237309c08edf ]

Fix a wrong error return by dropping an error return.

When vidi driver is remvoed, if ctx->raw_edid isn't same as fake_edid_info
then only what we have to is to free ctx->raw_edid so that driver removing
can work correctly - it's not an error case.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/exynos/exynos_drm_vidi.c

index 65b891cb9c50b0f9ef570e8ab14407d9bd02babb..d882a22dfd6e6b9cada10633284bd401964b7e4d 100644 (file)
@@ -483,8 +483,6 @@ static int vidi_remove(struct platform_device *pdev)
        if (ctx->raw_edid != (struct edid *)fake_edid_info) {
                kfree(ctx->raw_edid);
                ctx->raw_edid = NULL;
-
-               return -EINVAL;
        }
 
        component_del(&pdev->dev, &vidi_component_ops);