]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
Fix error handling in _PySys_UpdateConfig() (GH-109524)
authorSerhiy Storchaka <storchaka@gmail.com>
Mon, 18 Sep 2023 17:09:59 +0000 (20:09 +0300)
committerGitHub <noreply@github.com>
Mon, 18 Sep 2023 17:09:59 +0000 (20:09 +0300)
Python/sysmodule.c

index fed12812a77089f473a1bb49163fb224b8b82b05..9c1ee0215d7cf6b3976198800ba53599013df84c 100644 (file)
@@ -3502,7 +3502,9 @@ _PySys_UpdateConfig(PyThreadState *tstate)
     if (config->pycache_prefix != NULL) {
         SET_SYS_FROM_WSTR("pycache_prefix", config->pycache_prefix);
     } else {
-        PyDict_SetItemString(sysdict, "pycache_prefix", Py_None);
+        if (PyDict_SetItemString(sysdict, "pycache_prefix", Py_None) < 0) {
+            return -1;
+        }
     }
 
     COPY_LIST("argv", config->argv);
@@ -3516,7 +3518,9 @@ _PySys_UpdateConfig(PyThreadState *tstate)
         SET_SYS_FROM_WSTR("_stdlib_dir", stdlibdir);
     }
     else {
-        PyDict_SetItemString(sysdict, "_stdlib_dir", Py_None);
+        if (PyDict_SetItemString(sysdict, "_stdlib_dir", Py_None) < 0) {
+            return -1;
+        }
     }
 
 #undef SET_SYS_FROM_WSTR
@@ -3526,6 +3530,9 @@ _PySys_UpdateConfig(PyThreadState *tstate)
     // sys.flags
     PyObject *flags = _PySys_GetObject(interp, "flags"); // borrowed ref
     if (flags == NULL) {
+        if (!_PyErr_Occurred(tstate)) {
+            _PyErr_SetString(tstate, PyExc_RuntimeError, "lost sys.flags");
+        }
         return -1;
     }
     if (set_flags_from_config(interp, flags) < 0) {