ACPICA: executer/exsystem: Don't nag user about every Stall() violating the spec

ACPICA commit 129b75516fc49fe1fd6b8c5798f86c13854630b3

Stop nagging user about every Stall() that violates the spec

On my Dell XPS 15 7590 I get hundreds of these warnings after few hours of
uptime:

$ dmesg | grep "fix the firmware" | wc -l
261

I cannot fix the firmware and I doubt that Dell cares about 4 year old
laptop either

Fixes: ace8f1c54a02 ("ACPICA: executer/exsystem: Inform users about ACPI spec violation")
Link: https://github.com/acpica/acpica/commit/129b7551
Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

diff --git a/drivers/acpi/acpica/exsystem.c b/drivers/acpi/acpica/exsystem.c
index f665ffd9a396cfac710ed38fb53aeca9cc8f28dc..2c384bd52b9c4b8e10d401138034981fae7070ab 100644 (file)
--- a/drivers/acpi/acpica/exsystem.c
+++ b/drivers/acpi/acpica/exsystem.c
@@ -133,14 +133,15 @@ acpi_status acpi_ex_system_do_stall(u32 how_long_us)
                 * (ACPI specifies 100 usec as max, but this gives some slack in
                 * order to support existing BIOSs)
                 */
-               ACPI_ERROR((AE_INFO,
-                           "Time parameter is too large (%u)", how_long_us));
+               ACPI_ERROR_ONCE((AE_INFO,
+                                "Time parameter is too large (%u)",
+                                how_long_us));
                status = AE_AML_OPERAND_VALUE;
        } else {
                if (how_long_us > 100) {
-                       ACPI_WARNING((AE_INFO,
-                                     "Time parameter %u us > 100 us violating ACPI spec, please fix the firmware.",
-                                     how_long_us));
+                       ACPI_WARNING_ONCE((AE_INFO,
+                                          "Time parameter %u us > 100 us violating ACPI spec, please fix the firmware.",
+                                          how_long_us));
                }
                acpi_os_stall(how_long_us);
        }