]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/etnaviv: Use 'unsigned' type to count the number of pages
authorSui Jingfeng <sui.jingfeng@linux.dev>
Sun, 8 Sep 2024 12:11:04 +0000 (20:11 +0800)
committerLucas Stach <l.stach@pengutronix.de>
Mon, 28 Oct 2024 15:30:15 +0000 (16:30 +0100)
The unpin_user_pages() function takes an 'unsigned long' argument to
store the number of userspace pages, and the struct drm_gem_object::size
is a size_t type. The number of pages can not be negative, hence, use
'unsigned' variable to count the number of pages.

Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
drivers/gpu/drm/etnaviv/etnaviv_gem.c

index 5c0c9d4e3be183b694d9432caa10c1df26113478..63b7e143c273efb72045fa33c9bcef8f49c83169 100644 (file)
@@ -686,7 +686,7 @@ static void etnaviv_gem_userptr_release(struct etnaviv_gem_object *etnaviv_obj)
                kfree(etnaviv_obj->sgt);
        }
        if (etnaviv_obj->pages) {
-               int npages = etnaviv_obj->base.size >> PAGE_SHIFT;
+               unsigned int npages = etnaviv_obj->base.size >> PAGE_SHIFT;
 
                unpin_user_pages(etnaviv_obj->pages, npages);
                kvfree(etnaviv_obj->pages);