gimple-ssa-evrp-analyze.h (class evrp_range_analyzer): Add m_update_global_ranges...

	* gimple-ssa-evrp-analyze.h (class evrp_range_analyzer): Add
	m_update_global_ranges member.  Add corresponding argument to ctor.
	* gimple-ssa-evrp-analyze.c
	(evrp_range_analyzer::evrp_range_analyzer): Add new argument and
	initialize m_update_global_ranges.
	(evrp_range_analyzer::set_ssa_range_info): Assert that we are
	updating global ranges.
	(evrp_range_analyzer::record_ranges_from_incoming_edge): Only
	update global ranges if explicitly requested.
	(evrp_range_analyzer::record_ranges_from_phis): Similarly.
	(evrp_range_analyzer::record_ranges_from_stmt): Similarly.
	* gimple-ssa-evrp.c (evrp_dom_walker): Pass new argument to
	evrp_range_analyzer ctor.
	* gimple-ssa-sprintf.c (sprintf_dom_walker): Similarly.
	* tree-ssa-dom.c (dom_opt_dom_walker): Similarly.

	* gcc.c-torture/builtins/strnlen.x: New file to filter -Og from
	options to test.

From-SVN: r266897

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 3f83c29dc36b9c472876dfcddd8e6986a16c8b91..9ee432d2260489705dfa0a67f766111d5b75637b 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,22 @@
+2018-12-07  Jeff Law  <law@redhat.com>
+
+       PR middle-end/87813
+       * gimple-ssa-evrp-analyze.h (class evrp_range_analyzer): Add
+       m_update_global_ranges member.  Add corresponding argument to ctor.
+       * gimple-ssa-evrp-analyze.c
+       (evrp_range_analyzer::evrp_range_analyzer): Add new argument and
+       initialize m_update_global_ranges.
+       (evrp_range_analyzer::set_ssa_range_info): Assert that we are
+       updating global ranges.
+       (evrp_range_analyzer::record_ranges_from_incoming_edge): Only
+       update global ranges if explicitly requested.
+       (evrp_range_analyzer::record_ranges_from_phis): Similarly.
+       (evrp_range_analyzer::record_ranges_from_stmt): Similarly.
+       * gimple-ssa-evrp.c (evrp_dom_walker): Pass new argument to
+       evrp_range_analyzer ctor.
+       * gimple-ssa-sprintf.c (sprintf_dom_walker): Similarly.
+       * tree-ssa-dom.c (dom_opt_dom_walker): Similarly.
+
 2018-12-07  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
 
        * config/aarch64/aarch64-opts.h (aarch64_sve_vector_bits_enum):

diff --git a/gcc/gimple-ssa-evrp-analyze.c b/gcc/gimple-ssa-evrp-analyze.c
index 220dde093b53c90f91046adcea29bd0a6dbea17e..3efaca1a994f3b0ab95df565810e1ff3dabe8f00 100644 (file)
--- a/gcc/gimple-ssa-evrp-analyze.c
+++ b/gcc/gimple-ssa-evrp-analyze.c
@@ -42,7 +42,8 @@ along with GCC; see the file COPYING3.  If not see
 #include "vr-values.h"
 #include "gimple-ssa-evrp-analyze.h"
 
-evrp_range_analyzer::evrp_range_analyzer () : stack (10)
+evrp_range_analyzer::evrp_range_analyzer (bool update_global_ranges)
+  : stack (10), m_update_global_ranges (update_global_ranges)
 {
   edge e;
   edge_iterator ei;
@@ -107,6 +108,8 @@ evrp_range_analyzer::try_find_new_range (tree name,
 void
 evrp_range_analyzer::set_ssa_range_info (tree lhs, value_range *vr)
 {
+  gcc_assert (m_update_global_ranges);
+
   /* Set the SSA with the value range.  */
   if (INTEGRAL_TYPE_P (TREE_TYPE (lhs)))
     {
@@ -213,6 +216,7 @@ evrp_range_analyzer::record_ranges_from_incoming_edge (basic_block bb)
                continue;
              push_value_range (vrs[i].first, vrs[i].second);
              if (is_fallthru
+                 && m_update_global_ranges
                  && all_uses_feed_or_dominated_by_stmt (vrs[i].first, stmt))
                {
                  set_ssa_range_info (vrs[i].first, vrs[i].second);
@@ -267,7 +271,8 @@ evrp_range_analyzer::record_ranges_from_phis (basic_block bb)
       vr_values->update_value_range (lhs, &vr_result);
 
       /* Set the SSA with the value range.  */
-      set_ssa_range_info (lhs, &vr_result);
+      if (m_update_global_ranges)
+       set_ssa_range_info (lhs, &vr_result);
     }
 }
 
@@ -309,7 +314,8 @@ evrp_range_analyzer::record_ranges_from_stmt (gimple *stmt, bool temporary)
              /* Case one.  We can just update the underlying range
                 information as well as the global information.  */
              vr_values->update_value_range (output, &vr);
-             set_ssa_range_info (output, &vr);
+             if (m_update_global_ranges)
+               set_ssa_range_info (output, &vr);
            }
          else
            {

diff --git a/gcc/gimple-ssa-evrp-analyze.h b/gcc/gimple-ssa-evrp-analyze.h
index 0d2b4188b8c5d1f55bc7185bff518d59d98b5f62..01942f063629dd88906811a443418c5c8746ac16 100644 (file)
--- a/gcc/gimple-ssa-evrp-analyze.h
+++ b/gcc/gimple-ssa-evrp-analyze.h
@@ -23,7 +23,7 @@ along with GCC; see the file COPYING3.  If not see
 class evrp_range_analyzer
 {
  public:
-  evrp_range_analyzer (void);
+  evrp_range_analyzer (bool update_global_ranges);
   ~evrp_range_analyzer (void)
   {
     delete vr_values;
@@ -70,6 +70,9 @@ class evrp_range_analyzer
 
   /* STACK holds the old VR.  */
   auto_vec<std::pair <tree, value_range*> > stack;
+
+  /* True if we are updating global ranges, false otherwise.  */
+  bool m_update_global_ranges;
 };
 
 #endif /* GCC_GIMPLE_SSA_EVRP_ANALYZE_H */

diff --git a/gcc/gimple-ssa-evrp.c b/gcc/gimple-ssa-evrp.c
index deb45cdb9f62580d829cdd71a1964b6071db607b..9900980aecfd90b5c2dc42676dc5597a31f4c778 100644 (file)
--- a/gcc/gimple-ssa-evrp.c
+++ b/gcc/gimple-ssa-evrp.c
@@ -70,6 +70,7 @@ class evrp_dom_walker : public dom_walker
 public:
   evrp_dom_walker ()
     : dom_walker (CDI_DOMINATORS),
+      evrp_range_analyzer (true),
       evrp_folder (evrp_range_analyzer.get_vr_values ())
     {
       need_eh_cleanup = BITMAP_ALLOC (NULL);

diff --git a/gcc/gimple-ssa-sprintf.c b/gcc/gimple-ssa-sprintf.c
index 456a7d400115713a6600b1ce7bb303b6c971550e..00485d9a0735a3ca6aae48a6010dddcc353d558c 100644 (file)
--- a/gcc/gimple-ssa-sprintf.c
+++ b/gcc/gimple-ssa-sprintf.c
@@ -121,7 +121,9 @@ struct format_result;
 class sprintf_dom_walker : public dom_walker
 {
  public:
-  sprintf_dom_walker () : dom_walker (CDI_DOMINATORS) {}
+  sprintf_dom_walker ()
+    : dom_walker (CDI_DOMINATORS),
+      evrp_range_analyzer (false) {}
   ~sprintf_dom_walker () {}
 
   edge before_dom_children (basic_block) FINAL OVERRIDE;

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 8ad888d1fa917f73d684a629909cee9e4f03cd4f..8f63e819e8bf041e4a80f5f79487b9f5bd0d9285 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2018-12-07  Jeff Law  <law@redhat.com>
+
+       PR middle-end/87813
+       * gcc.c-torture/builtins/strnlen.x: New file to filter -Og from
+       options to test.
+
 2018-12-07  Vladimir Makarov  <vmakarov@redhat.com>
 
        PR rtl-optimization/88349

diff --git a/gcc/testsuite/gcc.c-torture/execute/builtins/strnlen.x b/gcc/testsuite/gcc.c-torture/execute/builtins/strnlen.x
new file mode 100644 (file)
index 0000000..9ee8a52
--- /dev/null
+++ b/gcc/testsuite/gcc.c-torture/execute/builtins/strnlen.x
@@ -0,0 +1,14 @@
+# At -Og no pass records the global range information
+# necessary to optimize the strnlen calls down to
+# a constant.  The framework assumes that the test
+# will never call strnlen when the optimizer is
+# enabled.  So we filter out the -Og run here.
+
+set torture_eval_before_compile {
+  if {[string match {*-Og*} "$option"]} {
+    continue
+  }
+}
+
+return 0
+

diff --git a/gcc/tree-ssa-dom.c b/gcc/tree-ssa-dom.c
index ce840488403bd0bc9b18d4dca36bc45251161ad5..e3e009a0e63a89e6495b9f70ef05d663c316da9e 100644 (file)
--- a/gcc/tree-ssa-dom.c
+++ b/gcc/tree-ssa-dom.c
@@ -578,6 +578,7 @@ public:
     : dom_walker (direction, REACHABLE_BLOCKS),
       m_const_and_copies (const_and_copies),
       m_avail_exprs_stack (avail_exprs_stack),
+      evrp_range_analyzer (true),
       m_dummy_cond (dummy_cond) { }
 
   virtual edge before_dom_children (basic_block);