]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
remove check of pending in ossl_quic_free
authorNeil Horman <nhorman@openssl.org>
Wed, 22 Jan 2025 15:25:47 +0000 (10:25 -0500)
committerNeil Horman <nhorman@openssl.org>
Mon, 17 Feb 2025 16:27:33 +0000 (11:27 -0500)
Not strictly needed

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/26361)

ssl/quic/quic_impl.c

index 79bf0edc3c8ac77dc869d0aad46e7f7f1aad01b6..cade45de441e753f9691895805e9f3bd479e3ec5 100644 (file)
@@ -805,13 +805,7 @@ void ossl_quic_free(SSL *s)
     qc_cleanup(ctx.qc, /*have_lock=*/1);
     /* Note: SSL_free calls OPENSSL_free(qc) for us */
 
-    /*
-     * Just because we have a listener doesn't mean we have a ref on it
-     * QUIC pre-creates user ssls to return to applications.
-     * Those don't hold a reference until they are accepted, so only drop
-     * the count if the application has accepted them
-     */
-    if (ctx.qc->pending == 0 && ctx.qc->listener != NULL)
+    if (ctx.qc->listener != NULL)
         SSL_free(&ctx.qc->listener->obj.ssl);
     if (ctx.qc->domain != NULL)
         SSL_free(&ctx.qc->domain->obj.ssl);