[#3831] C++17 clang fixes

diff --git a/src/bin/d2/tests/d2_cfg_mgr_unittests.cc b/src/bin/d2/tests/d2_cfg_mgr_unittests.cc
index 9bb1e89a4b0fad19a18f0d58d765dd7604fb1cb8..42983a607dc6fe4d442e7a132b0b95d134284f1c 100644 (file)
--- a/src/bin/d2/tests/d2_cfg_mgr_unittests.cc
+++ b/src/bin/d2/tests/d2_cfg_mgr_unittests.cc
@@ -242,7 +242,7 @@ public:
 };
 
 /// @brief Convenience macros for invoking runOrConfig()
-#define RUN_CONFIG_OK(a) (runConfigOrFail(a, NO_ERROR, ""))
+#define RUN_CONFIG_OK(a) (static_cast<void>(runConfigOrFail(a, NO_ERROR, "")))
 #define SYNTAX_ERROR(a,b) ASSERT_TRUE(runConfigOrFail(a,SYNTAX_ERROR,b))
 #define LOGIC_ERROR(a,b) ASSERT_TRUE(runConfigOrFail(a,LOGIC_ERROR,b))
 

diff --git a/src/bin/d2/tests/d2_process_unittests.cc b/src/bin/d2/tests/d2_process_unittests.cc
index 1e7c04b68661d338b938ccd3d7d25acf993379b4..315d68d8fdd794acb80529228cdc531408c7004b 100644 (file)
--- a/src/bin/d2/tests/d2_process_unittests.cc
+++ b/src/bin/d2/tests/d2_process_unittests.cc
@@ -647,7 +647,7 @@ TEST_F(D2ProcessTest, notLoopbackTest) {
     // Note we don't care nor can we predict if this
     // succeeds or fails. The address and port may or may
     // not be valid on the test host.
-    runWithConfig(config);
+    static_cast<void>(runWithConfig(config));
 }
 
 /// @brief Used to permit visual inspection of logs to ensure

diff --git a/src/bin/dhcp4/tests/direct_client_unittest.cc b/src/bin/dhcp4/tests/direct_client_unittest.cc
index 390862a5c57c8fdfaf988944675e4d18483524c6..668a5ba1c2ce9439ce2a1555a321963a1d744131 100644 (file)
--- a/src/bin/dhcp4/tests/direct_client_unittest.cc
+++ b/src/bin/dhcp4/tests/direct_client_unittest.cc
@@ -219,7 +219,7 @@ DirectClientTest::createClientMessage(const Pkt4Ptr& msg,
     // local and remote address are set like it was a message sent from the
     // directly connected client.
     Pkt4Ptr received;
-    createPacketFromBuffer(msg, received);
+    static_cast<void>(createPacketFromBuffer(msg, received));
     received->setIface(iface);
     received->setIndex(ifindex);
     received->setLocalAddr(IOAddress("255.255.255.255"));

diff --git a/src/lib/process/tests/d_cfg_mgr_unittests.cc b/src/lib/process/tests/d_cfg_mgr_unittests.cc
index 7cfa746a857999d43aecc9e129f366e454a81980..676abb27dbacd6b6708c90512359c173c02b52e2 100644 (file)
--- a/src/lib/process/tests/d_cfg_mgr_unittests.cc
+++ b/src/lib/process/tests/d_cfg_mgr_unittests.cc
@@ -260,7 +260,7 @@ TEST_F(DStubCfgMgrTest, simpleParseConfig) {
     string config = "{ \"bool_test\": true , \n"
                     "  \"uint32_test\": 77 , \n"
                     "  \"string_test\": \"hmmm chewy\" }";
-    ASSERT_NO_THROW(fromJSON(config));
+    ASSERT_NO_THROW(static_cast<void>(fromJSON(config)));
 
     answer_ = cfg_mgr_->simpleParseConfig(config_set_, false);
     EXPECT_TRUE(checkAnswer(0));
@@ -272,7 +272,7 @@ TEST_F(DStubCfgMgrTest, simpleParseConfigWithCallback) {
     string config = "{ \"bool_test\": true , \n"
                     "  \"uint32_test\": 77 , \n"
                     "  \"string_test\": \"hmmm chewy\" }";
-    ASSERT_NO_THROW(fromJSON(config));
+    ASSERT_NO_THROW(static_cast<void>(fromJSON(config)));
 
     answer_ = cfg_mgr_->simpleParseConfig(config_set_, false,
                                           []() {