]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mfd: rsmu: Split core code into separate module
authorArnd Bergmann <arnd@arndb.de>
Wed, 29 May 2024 09:48:47 +0000 (11:48 +0200)
committerLee Jones <lee@kernel.org>
Thu, 4 Jul 2024 16:08:02 +0000 (17:08 +0100)
Linking a file into two modules can have unintended side-effects
and produces a W=1 warning:

scripts/Makefile.build:236: drivers/mfd/Makefile: rsmu_core.o is added to multiple modules: rsmu-i2c rsmu-spi

Make this one a separate module instead.

Fixes: a1867f85e06e ("mfd: Add Renesas Synchronization Management Unit (SMU) support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20240529094856.1869543-1-arnd@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/Makefile
drivers/mfd/rsmu_core.c

index ce38d643009f6dbe667ab14c7c502003519f6015..02b651cd75352120c5f76393c81031c2e8eb153d 100644 (file)
@@ -286,7 +286,5 @@ obj-$(CONFIG_MFD_INTEL_M10_BMC_PMCI)   += intel-m10-bmc-pmci.o
 obj-$(CONFIG_MFD_ATC260X)      += atc260x-core.o
 obj-$(CONFIG_MFD_ATC260X_I2C)  += atc260x-i2c.o
 
-rsmu-i2c-objs                  := rsmu_core.o rsmu_i2c.o
-rsmu-spi-objs                  := rsmu_core.o rsmu_spi.o
-obj-$(CONFIG_MFD_RSMU_I2C)     += rsmu-i2c.o
-obj-$(CONFIG_MFD_RSMU_SPI)     += rsmu-spi.o
+obj-$(CONFIG_MFD_RSMU_I2C)     += rsmu_i2c.o rsmu_core.o
+obj-$(CONFIG_MFD_RSMU_SPI)     += rsmu_spi.o rsmu_core.o
index 29437fd0bd5bf68a04f35a96d206203bd3d985f0..fd04a6e5dfa31ac540ca078ad024f7abf05046de 100644 (file)
@@ -78,11 +78,13 @@ int rsmu_core_init(struct rsmu_ddata *rsmu)
 
        return ret;
 }
+EXPORT_SYMBOL_GPL(rsmu_core_init);
 
 void rsmu_core_exit(struct rsmu_ddata *rsmu)
 {
        mutex_destroy(&rsmu->lock);
 }
+EXPORT_SYMBOL_GPL(rsmu_core_exit);
 
 MODULE_DESCRIPTION("Renesas SMU core driver");
 MODULE_LICENSE("GPL");