httpclient: Keep better track of all sorts of references

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

diff --git a/src/libpakfire/httpclient.c b/src/libpakfire/httpclient.c
index c272c3b611235df48284b016e5633a823ffcd2a9..4e068eba65ac250c9de5e994590da6f754a5b263 100644 (file)
--- a/src/libpakfire/httpclient.c
+++ b/src/libpakfire/httpclient.c
@@ -430,11 +430,8 @@ static void pakfire_httpclient_free(struct pakfire_httpclient* client) {
        struct pakfire_httpclient_xfer* e = NULL;
 
        // Free any xfers that we still hold
-       for (;;) {
+       while (!TAILQ_EMPTY(&client->xfers)) {
                e = TAILQ_LAST(&client->xfers, xfers);
-               if (!e)
-                       break;
-
                TAILQ_REMOVE(&client->xfers, e, nodes);
 
                pakfire_httpclient_xfer_free(e);
@@ -581,6 +578,9 @@ int pakfire_httpclient_remove_xfer(struct pakfire_httpclient* client,
                goto ERROR;
        }
 
+       if (e)
+               TAILQ_REMOVE(&client->xfers, e, nodes);
+
 ERROR:
        if (e)
                pakfire_httpclient_xfer_free(e);