gpio: shared: check if a reference is populated before cleaning its resources

It's possible that not all proxy entries will be set up when the device
gets removed so check if they are before trying to dereference members
which are still NULL. This can happen if some consumers never requested
their shared GPIOs.

Fixes: a060b8c511ab ("gpiolib: implement low-level, shared GPIO support")
Link: https://lore.kernel.org/r/20251206-gpio-shared-teardown-fixes-v1-2-35ac458cfce1@oss.qualcomm.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

diff --git a/drivers/gpio/gpiolib-shared.c b/drivers/gpio/gpiolib-shared.c
index 17da15c1075f97f4ebed969b38197ac155141406..4084a28a953a7c9f4b04cbf867b05a1a74b557ca 100644 (file)
--- a/drivers/gpio/gpiolib-shared.c
+++ b/drivers/gpio/gpiolib-shared.c
@@ -491,10 +491,13 @@ void gpio_device_teardown_shared(struct gpio_device *gdev)
                        continue;
 
                list_for_each_entry(ref, &entry->refs, list) {
-                       gpiod_remove_lookup_table(ref->lookup);
-                       kfree(ref->lookup->table[0].key);
-                       kfree(ref->lookup);
-                       ref->lookup = NULL;
+                       if (ref->lookup) {
+                               gpiod_remove_lookup_table(ref->lookup);
+                               kfree(ref->lookup->table[0].key);
+                               kfree(ref->lookup);
+                               ref->lookup = NULL;
+                       }
+
                        gpio_shared_remove_adev(&ref->adev);
                }
        }