]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ACPI: property: use min() instead of min_t()
authorDavid Laight <david.laight.linux@gmail.com>
Wed, 19 Nov 2025 22:41:09 +0000 (22:41 +0000)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 24 Nov 2025 19:45:38 +0000 (20:45 +0100)
min_t(unsigned int, a, b) casts an 'unsigned long' to 'unsigned int'.
Use min(a, b) instead as it promotes any 'unsigned int' to 'unsigned long'
and so cannot discard significant bits.

In this case the 'unsigned long' value is small enough that the result
is ok.

Detected by an extra check added to min_t().

Signed-off-by: David Laight <david.laight.linux@gmail.com>
[ rjw: Subject adjustment ]
Link: https://patch.msgid.link/20251119224140.8616-14-david.laight.linux@gmail.com
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/property.c

index 57a9c18ec6732b599d587247fa64e8e53d12dd5d..18e90067d567244d1b0710ba1f17156cec6d2029 100644 (file)
@@ -1280,7 +1280,7 @@ static int acpi_data_prop_read(const struct acpi_device_data *data,
                ret = acpi_copy_property_array_uint(items, (u64 *)val, nval);
                break;
        case DEV_PROP_STRING:
-               nval = min_t(u32, nval, obj->package.count);
+               nval = min(nval, obj->package.count);
                if (nval == 0)
                        return -ENODATA;