]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/rcar-du: dsi: Document PHTR TESTDOUT as bitfield
authorMarek Vasut <marek.vasut+renesas@mailbox.org>
Tue, 28 Oct 2025 23:28:13 +0000 (00:28 +0100)
committerTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Wed, 29 Oct 2025 09:32:11 +0000 (11:32 +0200)
The register PHTR bitfield TESTDOUT is not a single bit, but a
bitfield. Add a MASK macro and a _TEST bitfield value, which is
used by the driver to poll for completion. No functional change.

Reviewed-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Link: https://patch.msgid.link/20251028232959.109936-4-marek.vasut+renesas@mailbox.org
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c
drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi_regs.h

index 5c73a513f678ecc1b7d088c187cb0c751c049a39..c24721a1eddf284ab5e4ab07f15541a6880fda1f 100644 (file)
@@ -316,8 +316,8 @@ rcar_mipi_dsi_post_init_phtw_v4h(struct rcar_mipi_dsi *dsi,
                WRITE_PHTW(0x01020100, 0x00000180);
 
                ret = read_poll_timeout(rcar_mipi_dsi_read, status,
-                                       status & PHTR_TEST, 2000, 10000, false,
-                                       dsi, PHTR);
+                                       status & PHTR_TESTDOUT_TEST,
+                                       2000, 10000, false, dsi, PHTR);
                if (ret < 0) {
                        dev_err(dsi->dev, "failed to test PHTR\n");
                        return ret;
index b8a719a13c006656c5dacb8ecbe74c730b3511dc..62341416ac6e9b0c2eca5b1a7dd00b6cb0d14310 100644 (file)
 #define PHTW_TESTDIN_CODE(x)           (((x) & 0xff) << 0)
 
 #define PHTR                           0x1038
-#define PHTR_TEST                      (1 << 16)
+#define PHTR_TESTDOUT                  (0xff << 16)
+#define PHTR_TESTDOUT_TEST             (1 << 16)
 
 #define PHTC                           0x103c
 #define PHTC_TESTCLR                   (1 << 0)