]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: Constify struct pci_device_id
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 7 Dec 2024 16:48:28 +0000 (17:48 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 10 Dec 2024 02:59:52 +0000 (21:59 -0500)
'struct pci_device_id' is not modified in these drivers.

Constifying this structure moves some data to a read-only section, so
increase overall security.

On a x86_64, with allmodconfig, as an example:
Before:
======
   text    data     bss     dec     hex filename
  70237    9137     320   79694   1374e drivers/scsi/3w-9xxx.o

After:
=====
   text    data     bss     dec     hex filename
  70461    8913     320   79694   1374e drivers/scsi/3w-9xxx.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/fc61b1946488c1ea8f7a17a06cf40fbd05dcc6de.1733590049.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
32 files changed:
drivers/scsi/3w-9xxx.c
drivers/scsi/3w-sas.c
drivers/scsi/3w-xxxx.c
drivers/scsi/BusLogic.c
drivers/scsi/a100u2w.c
drivers/scsi/advansys.c
drivers/scsi/am53c974.c
drivers/scsi/arcmsr/arcmsr_hba.c
drivers/scsi/atp870u.c
drivers/scsi/cxlflash/main.c
drivers/scsi/dc395x.c
drivers/scsi/dmx3191d.c
drivers/scsi/elx/efct/efct_driver.c
drivers/scsi/fdomain_pci.c
drivers/scsi/fnic/fnic_main.c
drivers/scsi/hptiop.c
drivers/scsi/initio.c
drivers/scsi/ipr.c
drivers/scsi/megaraid.c
drivers/scsi/megaraid/megaraid_mbox.c
drivers/scsi/megaraid/megaraid_sas_base.c
drivers/scsi/mvsas/mv_init.c
drivers/scsi/nsp32.c
drivers/scsi/pm8001/pm8001_init.c
drivers/scsi/pmcraid.c
drivers/scsi/qedi/qedi_main.c
drivers/scsi/qla1280.c
drivers/scsi/qla2xxx/qla_os.c
drivers/scsi/qla4xxx/ql4_os.c
drivers/scsi/snic/snic_main.c
drivers/scsi/stex.c
drivers/scsi/sym53c8xx_2/sym_glue.c

index 97bcdf84386ddd47b6bf511e3b98c041f96805ba..883d4a12a1722ebc3c03f0e8930dcefc473c0afb 100644 (file)
@@ -2261,7 +2261,7 @@ out_disable_device:
 } /* End twa_resume() */
 
 /* PCI Devices supported by this driver */
-static struct pci_device_id twa_pci_tbl[] = {
+static const struct pci_device_id twa_pci_tbl[] = {
        { PCI_VENDOR_ID_3WARE, PCI_DEVICE_ID_3WARE_9000,
          PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
        { PCI_VENDOR_ID_3WARE, PCI_DEVICE_ID_3WARE_9550SX,
index 8ed7126d82bb3d4170557053605e389bd18bf63d..9b6eab3b1e4d474a607820ca179fa5a39a8bc187 100644 (file)
@@ -1822,7 +1822,7 @@ out_disable_device:
 } /* End twl_resume() */
 
 /* PCI Devices supported by this driver */
-static struct pci_device_id twl_pci_tbl[] = {
+static const struct pci_device_id twl_pci_tbl[] = {
        { PCI_VDEVICE(3WARE, PCI_DEVICE_ID_3WARE_9750) },
        { }
 };
index 82fb9dc8dac93b0fca8af52675b406e11371bb48..89bd56f78ef90c513309a262dc513a163af763dd 100644 (file)
@@ -2393,7 +2393,7 @@ static void tw_remove(struct pci_dev *pdev)
 } /* End tw_remove() */
 
 /* PCI Devices supported by this driver */
-static struct pci_device_id tw_pci_tbl[] = {
+static const struct pci_device_id tw_pci_tbl[] = {
        { PCI_VENDOR_ID_3WARE, PCI_DEVICE_ID_3WARE_1000,
          PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
        { PCI_VENDOR_ID_3WARE, PCI_DEVICE_ID_3WARE_7000,
index d04b5feec2eb5212a979dcbd78747a16cd5f6ca0..1f100270cd385eeec8b057c47071444a05508d40 100644 (file)
@@ -3716,7 +3716,7 @@ static void __exit blogic_exit(void)
 __setup("BusLogic=", blogic_setup);
 
 #ifdef MODULE
-/*static struct pci_device_id blogic_pci_tbl[] = {
+/*static const struct pci_device_id blogic_pci_tbl[] = {
        { PCI_VENDOR_ID_BUSLOGIC, PCI_DEVICE_ID_BUSLOGIC_MULTIMASTER,
          PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
        { PCI_VENDOR_ID_BUSLOGIC, PCI_DEVICE_ID_BUSLOGIC_MULTIMASTER_NC,
index b95147fb18b07c6b7d52b3320660fc54f39f5a09..a8979f9e30ffe3f777620c34514cd3a6afd20311 100644 (file)
@@ -1206,7 +1206,7 @@ static void inia100_remove_one(struct pci_dev *pdev)
        scsi_host_put(shost);
 } 
 
-static struct pci_device_id inia100_pci_tbl[] = {
+static const struct pci_device_id inia100_pci_tbl[] = {
        {PCI_VENDOR_ID_INIT, 0x1060, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
        {0,}
 };
index 8fededa1a751d7eb9e570032f5e343844988828d..3a2c336307c09f84ee00cf6ddb1df38201a42ce9 100644 (file)
@@ -11409,7 +11409,7 @@ static struct eisa_driver advansys_eisa_driver = {
 };
 
 /* PCI Devices supported by this driver */
-static struct pci_device_id advansys_pci_tbl[] = {
+static const struct pci_device_id advansys_pci_tbl[] = {
        {PCI_VENDOR_ID_ASP, PCI_DEVICE_ID_ASP_1200A,
         PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
        {PCI_VENDOR_ID_ASP, PCI_DEVICE_ID_ASP_ABP940,
index fbb29dbb1e503947ac3cdec7a268cf32a685da87..003e61831e333456aaf0980e30234ff7ee93691b 100644 (file)
@@ -513,7 +513,7 @@ static void pci_esp_remove_one(struct pci_dev *pdev)
        scsi_host_put(esp->host);
 }
 
-static struct pci_device_id am53c974_pci_tbl[] = {
+static const struct pci_device_id am53c974_pci_tbl[] = {
        { PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_SCSI,
                PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
        { }
index 6a32e3e0d516881fd87a56a394607930582644ee..b76f241862e95922baf83c85e223802da5c62589 100644 (file)
@@ -172,7 +172,7 @@ static const struct scsi_host_template arcmsr_scsi_host_template = {
        .no_write_same          = 1,
 };
 
-static struct pci_device_id arcmsr_device_id_table[] = {
+static const struct pci_device_id arcmsr_device_id_table[] = {
        {PCI_DEVICE(PCI_VENDOR_ID_ARECA, PCI_DEVICE_ID_ARECA_1110),
                .driver_data = ACB_ADAPTER_TYPE_A},
        {PCI_DEVICE(PCI_VENDOR_ID_ARECA, PCI_DEVICE_ID_ARECA_1120),
index 928151ec927a314948c04077fc918f92d1ec1fab..401242912855b864d93c075cc79ab026ee9e6dd3 100644 (file)
@@ -1743,7 +1743,7 @@ static const struct scsi_host_template atp870u_template = {
      .max_sectors              = ATP870U_MAX_SECTORS,
 };
 
-static struct pci_device_id atp870u_id_table[] = {
+static const struct pci_device_id atp870u_id_table[] = {
        { PCI_DEVICE(PCI_VENDOR_ID_ARTOP, ATP885_DEVID)                   },
        { PCI_DEVICE(PCI_VENDOR_ID_ARTOP, ATP880_DEVID1)                  },
        { PCI_DEVICE(PCI_VENDOR_ID_ARTOP, ATP880_DEVID2)                  },
index 60d62b93d62442fae156f8521276f2c4f55daa50..76073a71c028305010b3391c7ff58b9775cbec23 100644 (file)
@@ -3177,7 +3177,7 @@ static struct dev_dependent_vals dev_briard_vals = { CXLFLASH_MAX_SECTORS,
 /*
  * PCI device binding table
  */
-static struct pci_device_id cxlflash_pci_table[] = {
+static const struct pci_device_id cxlflash_pci_table[] = {
        {PCI_VENDOR_ID_IBM, PCI_DEVICE_ID_IBM_CORSA,
         PCI_ANY_ID, PCI_ANY_ID, 0, 0, (kernel_ulong_t)&dev_corsa_vals},
        {PCI_VENDOR_ID_IBM, PCI_DEVICE_ID_IBM_FLASH_GT,
index 235ebc851ca94d73bcefd68891efa958d2ac15c3..e71de241975884583201e94cd3e48613be17be0e 100644 (file)
@@ -4668,7 +4668,7 @@ static void dc395x_remove_one(struct pci_dev *dev)
 }
 
 
-static struct pci_device_id dc395x_pci_table[] = {
+static const struct pci_device_id dc395x_pci_table[] = {
        {
                .vendor         = PCI_VENDOR_ID_TEKRAM,
                .device         = PCI_DEVICE_ID_TEKRAM_TRMS1040,
index dfb091d34363fc4d6996b89ed9b5bc4a32330311..d6d091b2f3c7918912569b939d8bd80cc33ab33a 100644 (file)
@@ -127,7 +127,7 @@ static void dmx3191d_remove_one(struct pci_dev *pdev)
        pci_disable_device(pdev);
 }
 
-static struct pci_device_id dmx3191d_pci_tbl[] = {
+static const struct pci_device_id dmx3191d_pci_tbl[] = {
        {PCI_VENDOR_ID_DOMEX, PCI_DEVICE_ID_DOMEX_DMX3191D,
                PCI_ANY_ID, PCI_ANY_ID, 0, 0, 4},
        { }
index 55d2301bfd7de81da17e43408046f347415a3e0a..8469c156ab3371dab4a9a4c61bc7bb21f93531db 100644 (file)
@@ -470,7 +470,7 @@ out:
        return rc;
 }
 
-static struct pci_device_id efct_pci_table[] = {
+static const struct pci_device_id efct_pci_table[] = {
        {PCI_DEVICE(EFCT_VENDOR_ID, EFCT_DEVICE_LANCER_G6), 0},
        {PCI_DEVICE(EFCT_VENDOR_ID, EFCT_DEVICE_LANCER_G7), 0},
        {}      /* terminate list */
index 3e05ce7b89e5d8c63a2e6ba64c05e5ae087c8c40..c15b2ce76e9f73ad8dc66b55d47007a5dfb0d442 100644 (file)
@@ -47,7 +47,7 @@ static void fdomain_pci_remove(struct pci_dev *pdev)
        pci_disable_device(pdev);
 }
 
-static struct pci_device_id fdomain_pci_table[] = {
+static const struct pci_device_id fdomain_pci_table[] = {
        { PCI_DEVICE(PCI_VENDOR_ID_FD, PCI_DEVICE_ID_FD_36C70) },
        {}
 };
index a6b6670547927729a99d7a82bf7c982f12b4b3ca..6772f3683a8c0098f57c4d7bc89a933e7a10fe11 100644 (file)
@@ -44,7 +44,7 @@ static DEFINE_SPINLOCK(fnic_list_lock);
 static DEFINE_IDA(fnic_ida);
 
 /* Supported devices by fnic module */
-static struct pci_device_id fnic_id_table[] = {
+static const struct pci_device_id fnic_id_table[] = {
        { PCI_DEVICE(PCI_VENDOR_ID_CISCO, PCI_DEVICE_ID_CISCO_FNIC) },
        { 0, }
 };
index 55eee5b0f0d77a4408095b225d5f2ba59c7cccea..21f1d9871a333fd6e9354c2a2492d226969dfed2 100644 (file)
@@ -1634,7 +1634,7 @@ static struct hptiop_adapter_ops hptiop_mvfrey_ops = {
        .host_phy_flag     = cpu_to_le64(1),
 };
 
-static struct pci_device_id hptiop_id_table[] = {
+static const struct pci_device_id hptiop_id_table[] = {
        { PCI_VDEVICE(TTI, 0x3220), (kernel_ulong_t)&hptiop_itl_ops },
        { PCI_VDEVICE(TTI, 0x3320), (kernel_ulong_t)&hptiop_itl_ops },
        { PCI_VDEVICE(TTI, 0x3410), (kernel_ulong_t)&hptiop_itl_ops },
index 625fd547ee60a79c3a8bae9e985cb74d06b9073f..8648bd96528734ebd75ffcd809d1314a1ccd0e97 100644 (file)
@@ -2941,7 +2941,7 @@ static void initio_remove_one(struct pci_dev *pdev)
 
 MODULE_LICENSE("GPL");
 
-static struct pci_device_id initio_pci_tbl[] = {
+static const struct pci_device_id initio_pci_tbl[] = {
        {PCI_VENDOR_ID_INIT, 0x9500, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
        {PCI_VENDOR_ID_INIT, 0x9400, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
        {PCI_VENDOR_ID_INIT, 0x9401, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
index f0444faf776a4fa82e7213206e8cdc8409ea8a87..1ea528f5d23dc399271878e1290c0483e7732dfa 100644 (file)
@@ -9844,7 +9844,7 @@ static void ipr_shutdown(struct pci_dev *pdev)
        }
 }
 
-static struct pci_device_id ipr_pci_table[] = {
+static const struct pci_device_id ipr_pci_table[] = {
        { PCI_VENDOR_ID_MYLEX, PCI_DEVICE_ID_IBM_GEMSTONE,
                PCI_VENDOR_ID_IBM, IPR_SUBS_DEV_ID_5702, 0, 0, 0 },
        { PCI_VENDOR_ID_MYLEX, PCI_DEVICE_ID_IBM_GEMSTONE,
index 38976f94453e0eea403bed17288dbf9183be50f9..adab151663dd853d7d7fe888ff5ab2aa9b963aa9 100644 (file)
@@ -4551,7 +4551,7 @@ megaraid_shutdown(struct pci_dev *pdev)
        __megaraid_shutdown(adapter);
 }
 
-static struct pci_device_id megaraid_pci_tbl[] = {
+static const struct pci_device_id megaraid_pci_tbl[] = {
        {PCI_VENDOR_ID_AMI, PCI_DEVICE_ID_AMI_MEGARAID,
                PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
        {PCI_VENDOR_ID_AMI, PCI_DEVICE_ID_AMI_MEGARAID2,
index 9463f11cc4c879373a45d19db833b4645b485e4c..60cc3372991fdcce5fb84b7dd0ea797ac0abc929 100644 (file)
@@ -199,7 +199,7 @@ MODULE_PARM_DESC(debug_level, "Debug level for driver (default=0)");
 /*
  * PCI table for all supported controllers.
  */
-static struct pci_device_id pci_id_table_g[] =  {
+static const struct pci_device_id pci_id_table_g[] =  {
        {
                PCI_VENDOR_ID_DELL,
                PCI_DEVICE_ID_PERC4_DI_DISCOVERY,
index 9739f389b1d0e7616a77bdb8a42a60d95ea22078..b59713130a524de9194ae406132eb592b61fe890 100644 (file)
@@ -147,7 +147,7 @@ megasas_set_ld_removed_by_fw(struct megasas_instance *instance);
 /*
  * PCI ID table for all supported controllers
  */
-static struct pci_device_id megasas_pci_table[] = {
+static const struct pci_device_id megasas_pci_table[] = {
 
        {PCI_DEVICE(PCI_VENDOR_ID_LSI_LOGIC, PCI_DEVICE_ID_LSI_SAS1064R)},
        /* xscale IOP */
index 020037cbf0d91dd28c9e95cf702d508493564391..2c72da6b8cf0c0a6833ea810cd7528bd70c8c186 100644 (file)
@@ -609,7 +609,7 @@ static void mvs_pci_remove(struct pci_dev *pdev)
        return;
 }
 
-static struct pci_device_id mvs_pci_table[] = {
+static const struct pci_device_id mvs_pci_table[] = {
        { PCI_VDEVICE(MARVELL, 0x6320), chip_6320 },
        { PCI_VDEVICE(MARVELL, 0x6340), chip_6440 },
        {
index b7987019686e9a93e4ed6fc56c1fe78f4b33e49d..abc4ce9eae742d33d7272574a9cc4d31bafc6841 100644 (file)
@@ -66,7 +66,7 @@ static const char *nsp32_release_version = "1.2";
 /****************************************************************************
  * Supported hardware
  */
-static struct pci_device_id nsp32_pci_table[] = {
+static const struct pci_device_id nsp32_pci_table[] = {
        {
                .vendor      = PCI_VENDOR_ID_IODATA,
                .device      = PCI_DEVICE_ID_NINJASCSI_32BI_CBSC_II,
index f8c81e53e93f7849bbe7fe9cbc861f22b964bc39..c32ceeba7ccb92cfe9bca7b127548b5efd5fa156 100644 (file)
@@ -1435,7 +1435,7 @@ err_out_disable:
 /* update of pci device, vendor id and driver data with
  * unique value for each of the controller
  */
-static struct pci_device_id pm8001_pci_table[] = {
+static const struct pci_device_id pm8001_pci_table[] = {
        { PCI_VDEVICE(PMC_Sierra, 0x8001), chip_8001 },
        { PCI_VDEVICE(PMC_Sierra, 0x8006), chip_8006 },
        { PCI_VDEVICE(ADAPTEC2, 0x8006), chip_8006 },
index 2342ded7ee7844c508b51f70a44c655130744f3a..3ba53916fd86b4cedc730f164516fbba683501ea 100644 (file)
@@ -113,7 +113,7 @@ static struct pmcraid_chip_details pmcraid_chip_cfg[] = {
 /*
  * PCI device ids supported by pmcraid driver
  */
-static struct pci_device_id pmcraid_pci_table[] = {
+static const struct pci_device_id pmcraid_pci_table[] = {
        { PCI_DEVICE(PCI_VENDOR_ID_PMC, PCI_DEVICE_ID_PMC_MAXRAID),
          0, 0, (kernel_ulong_t)&pmcraid_chip_cfg[0]
        },
index 628d59dda20cc40c4391441319d6ed8ae1afca66..1cab66a1f4f65a69eb778626fa89a846cb7633a3 100644 (file)
@@ -2869,7 +2869,7 @@ static void qedi_remove(struct pci_dev *pdev)
        __qedi_remove(pdev, QEDI_MODE_NORMAL);
 }
 
-static struct pci_device_id qedi_pci_tbl[] = {
+static const struct pci_device_id qedi_pci_tbl[] = {
        { PCI_DEVICE(PCI_VENDOR_ID_QLOGIC, 0x165E) },
        { PCI_DEVICE(PCI_VENDOR_ID_QLOGIC, 0x8084) },
        { 0 },
index 360867838abd0f4ae39fe6099d0a27a40436cd6b..1fd2da0264e38b3c9d58ae42373adc748de11413 100644 (file)
@@ -501,7 +501,7 @@ struct qla_boards {
 };
 
 /* NOTE: the last argument in each entry is used to index ql1280_board_tbl */
-static struct pci_device_id qla1280_pci_tbl[] = {
+static const struct pci_device_id qla1280_pci_tbl[] = {
        {PCI_VENDOR_ID_QLOGIC, PCI_DEVICE_ID_QLOGIC_ISP12160,
                PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
        {PCI_VENDOR_ID_QLOGIC, PCI_DEVICE_ID_QLOGIC_ISP1020,
index 6b7388cfc55e0d86633028e7ea881acdaa727663..056e6daff8a962553141b0aa912a83ca1b0c5f96 100644 (file)
@@ -8115,7 +8115,7 @@ static const struct pci_error_handlers qla2xxx_err_handler = {
        .reset_done = qla_pci_reset_done,
 };
 
-static struct pci_device_id qla2xxx_pci_tbl[] = {
+static const struct pci_device_id qla2xxx_pci_tbl[] = {
        { PCI_DEVICE(PCI_VENDOR_ID_QLOGIC, PCI_DEVICE_ID_QLOGIC_ISP2100) },
        { PCI_DEVICE(PCI_VENDOR_ID_QLOGIC, PCI_DEVICE_ID_QLOGIC_ISP2200) },
        { PCI_DEVICE(PCI_VENDOR_ID_QLOGIC, PCI_DEVICE_ID_QLOGIC_ISP2300) },
index 863071f80d390427c7935f3a5fc1f26cd34ad166..062ec5f247584eab1df040da3ea44d6889f70db4 100644 (file)
@@ -9846,7 +9846,7 @@ static const struct pci_error_handlers qla4xxx_err_handler = {
        .resume = qla4xxx_pci_resume,
 };
 
-static struct pci_device_id qla4xxx_pci_tbl[] = {
+static const struct pci_device_id qla4xxx_pci_tbl[] = {
        {
                .vendor         = PCI_VENDOR_ID_QLOGIC,
                .device         = PCI_DEVICE_ID_QLOGIC_ISP4010,
index d3cf50088a3728734bf4dcbd39cbac0bbae3efcb..1c24517e4e6501d38b9c68138c8dee536a3e6588 100644 (file)
@@ -21,7 +21,7 @@
 #define PCI_DEVICE_ID_CISCO_SNIC       0x0046
 
 /* Supported devices by snic module */
-static struct pci_device_id snic_id_table[] = {
+static const struct pci_device_id snic_id_table[] = {
        {PCI_DEVICE(0x1137, PCI_DEVICE_ID_CISCO_SNIC) },
        { 0, }  /* end of table */
 };
index 0e5c7609dcc43e5e4ab31d272750190e7ceeaf55..63ed7f9aaa93719824d4f59d604a301d4da5e165 100644 (file)
@@ -1488,7 +1488,7 @@ static const struct scsi_host_template driver_template = {
        .dma_boundary                   = PAGE_SIZE - 1,
 };
 
-static struct pci_device_id stex_pci_tbl[] = {
+static const struct pci_device_id stex_pci_tbl[] = {
        /* st_shasta */
        { 0x105a, 0x8350, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
                st_shasta }, /* SuperTrak EX8350/8300/16350/16300 */
index 9b8cb7319370aeec9fa3d2f31119c1d905265a0e..212d89d0d23e50687602ed36adcd676bbcc3c78d 100644 (file)
@@ -2031,7 +2031,7 @@ static struct spi_function_template sym2_transport_functions = {
        .get_signalling = sym2_get_signalling,
 };
 
-static struct pci_device_id sym2_id_table[] = {
+static const struct pci_device_id sym2_id_table[] = {
        { PCI_VENDOR_ID_LSI_LOGIC, PCI_DEVICE_ID_NCR_53C810,
          PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0UL },
        { PCI_VENDOR_ID_LSI_LOGIC, PCI_DEVICE_ID_NCR_53C820,